Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: predicates that return any will now behave property in TS #5987

Merged
merged 1 commit into from
Jan 26, 2021
Merged

fix: predicates that return any will now behave property in TS #5987

merged 1 commit into from
Jan 26, 2021

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Jan 26, 2021

Resolves #5986

@benlesh benlesh mentioned this pull request Jan 26, 2021
Merged
niklas-wortmann
niklas-wortmann approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benlesh benlesh merged commit f5ae97d into ReactiveX:master Jan 26, 2021
@cartant cartant mentioned this pull request Mar 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklas-wortmann niklas-wortmann niklas-wortmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some operators return the wrong type if a predicate returns any in TypeScript.
2 participants
@benlesh @niklas-wortmann