Skip to content

Translate Introducing JSX #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 24, 2019
Merged

Conversation

Haqverdi
Copy link
Contributor

İntroducing-jsx translate

İntroducing-jsx translate
@GasimGasimzada GasimGasimzada changed the title İntroducing-jsx translate Introducing JSX translate Feb 20, 2019
@netlify
Copy link

netlify bot commented Feb 20, 2019

Deploy preview for az-reactjs ready!

Built with commit a22052c

https://deploy-preview-27--az-reactjs.netlify.com

Copy link
Collaborator

@GasimGasimzada GasimGasimzada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, what is "simli"? It is a very confusing wording for the word "string." String stands for a string of characters, so it is better to use something like "mətn", "sətr", even "yazı." There are going to be times where showing the original text in parentheses would be useful (i.e translating a word that has essentially no translation in Azerbaijani). However, I think we should actually translate the word string as it has a translation.

Secondly, please refer to the glossary when translating the words and try to be consistent in wording -- you have places where you have written UI and Uİ (with Azerbaijani "İ"). Just from a quick look, you have written "bug" where there is definitely a translation in Azerbaijani called "baq." Tag = təq.

Thirdly, please fix make sure that your header capitalizations are aligned with the English version. For example, "JSX-də İfadələr **Y*erləşdirmə. Additionally, fix formatting issues. Add proper spaces between parentheses and texts. Foe example in line 132, you removed the space between section title and the link that is in curly braces.

  • Line 17: Fix typo: "xatırlata"
  • Line 19: Link does not work because there is space between square brackets and parentheses.
  • Line 23: applikasiya, not aplikasiya; remove parentheses for events
  • Line 25: you have used "bu" twice for the youtube link.
  • Line 25: Remove space between stars and text (* texnologiyaları *)
  • Line 25: The text does not match the underlying "Separation of Concerns" link. In order to link to Separation of Concerns, you need to have a word that at least defines it in the documentation
  • Line 47: Fix typo: "yerləşdirrik"
  • Line 77: Fix typo: "edilrikdən"
  • Line 112: Remove "children" parentheses
  • Line 142: "escape", not "escapes"

@GasimGasimzada GasimGasimzada merged commit 79acc42 into master Feb 24, 2019
@GasimGasimzada GasimGasimzada deleted the Haqverdi-introducing-jsx-translate branch July 30, 2019 12:56
@tesseralis tesseralis mentioned this pull request Oct 14, 2019
99 tasks
@GasimGasimzada GasimGasimzada added this to the Core milestone Oct 14, 2019
@GasimGasimzada GasimGasimzada changed the title Introducing JSX translate Translate Introducing JSX Oct 14, 2019
@GasimGasimzada GasimGasimzada added the new page Translate a new page label Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new page Translate a new page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants