Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context #142

Merged
merged 13 commits into from
Mar 28, 2020
Merged

Context #142

merged 13 commits into from
Mar 28, 2020

Conversation

hajarsadeghi
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Mar 27, 2020 •
edited
Loading

Deploy preview for fa-reactjs ready!

Built with commit 2eaa44b

https://deploy-preview-142--fa-reactjs.netlify.com

@hajarsadeghi
Copy link
Contributor Author

Hello to all the maintainers!
I translated the Context page under the advanced guides, the only problem that I was facing was the missing code blocks in some part of the page which prevented me from being able to translate the comments inside the code blocks! I'll be happy to know if I can by any means translate them also.
I'm waiting on your review, please feel free to let me know of the errors in my translation.
Thanks in advance.

rezvani2647
rezvani2647 reviewed Mar 28, 2020
View reviewed changes
Copy link
Member

@rezvani2647 rezvani2647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

با سلام
ترجمه شما عالی بود و هم حق مطلب به خوبی ادا شده بود هم بسیار روان بود.
فقط مطالب بسیار کوچکی به چشم خورد که براتون تصحیح کردم.
با سپاس از شما

content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
hajarsadeghi and others added 10 commits March 28, 2020 15:31
@hajarsadeghi
Update content/docs/context.md
3df268f 
suggestion accepted

Co-Authored-By: Abolfazl Rezvani Naraqi <rezvani2647@yahoo.com>
@hajarsadeghi
Update content/docs/context.md
72cbc47 
suggestion accepted

Co-Authored-By: Abolfazl Rezvani Naraqi <rezvani2647@yahoo.com>
@hajarsadeghi
Update content/docs/context.md
9bdfb4e 
suggestion accepted

Co-Authored-By: Abolfazl Rezvani Naraqi <rezvani2647@yahoo.com>
@hajarsadeghi
Update content/docs/context.md
76d8b1d 
suggestion approved

Co-Authored-By: Abolfazl Rezvani Naraqi <rezvani2647@yahoo.com>
@hajarsadeghi
Update content/docs/context.md
47e7b22 
suggestion accepted

Co-Authored-By: Abolfazl Rezvani Naraqi <rezvani2647@yahoo.com>
@hajarsadeghi
Update content/docs/context.md
695bbe5 
accepted

Co-Authored-By: Abolfazl Rezvani Naraqi <rezvani2647@yahoo.com>
@hajarsadeghi
Update content/docs/context.md
febb3fd 
suggestion accepted

Co-Authored-By: Abolfazl Rezvani Naraqi <rezvani2647@yahoo.com>
@hajarsadeghi
Update content/docs/context.md
de98e08 
suggestion accepted

Co-Authored-By: Abolfazl Rezvani Naraqi <rezvani2647@yahoo.com>
@hajarsadeghi
Update content/docs/context.md
435be8e 
suggestion accepted

Co-Authored-By: Abolfazl Rezvani Naraqi <rezvani2647@yahoo.com>
@hajarsadeghi
minor changes on review feedback
2eaa44b
@hajarsadeghi
Copy link
Contributor Author

خیلی ممنونم بابت review ترجمه من
خیلی خوشحالم که تو این پروژه با شما همکاری میکنم.
من تمام ریویوهای شما رو commit کردم٬ فقط دو تا مورد کوچیک دیدم که اگه اون ‌ها رو هم چک کنید ممنون میشم .

@rezvani2647
Copy link
Member

ممنون از همکاری شما.
امیدوارم بتتونیم بیشتر از شما استفاده کنیم.

@rezvani2647 rezvani2647 merged commit 2bc51a4 into reactjs:master Mar 28, 2020
@tesseralis tesseralis mentioned this pull request Mar 28, 2020
Closed
87 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rezvani2647 rezvani2647 rezvani2647 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hajarsadeghi @rezvani2647