Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fowrawrding Refs #150

Merged
merged 40 commits into from
Jun 25, 2020
Merged

Conversation

hosseinAMD
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jun 20, 2020

Deploy preview for fa-reactjs ready!

Built with commit ecf44d0

https://deploy-preview-150--fa-reactjs.netlify.app

@sorousht
Copy link
Collaborator

sorousht commented Jun 20, 2020

I guess you need to get the latest changes of branch master, and merge it into your own branch which is hosseinAMD-forwarding-refs-hosseinamd by following the below steps:

git checkout master
git pull origin master
git checkout hosseinAMD-forwarding-refs-hosseinamd
git merge master
git push [your-own-remote-name] hosseinAMD-forwarding-refs-hosseinamd

If you still have some troubles, let me know :)

@hosseinAMD
Copy link
Contributor Author

I guess you need to get the latest changes of branch master, and merge it into your own branch which is hosseinAMD-forwarding-refs-hosseinamd by following the below steps:

git checkout master
git pull origin master
git checkout hosseinAMD-forwarding-refs-hosseinamd
git merge master
git push [your-own-remote-name] hosseinAMD-forwarding-refs-hosseinamd

If you still have some troubles, let me know :)

@sorousht

I've ran every command you told me. but as you can see tests still fail
I can send you my translation .MD file to test if you have linux os!

@hosseinAMD
Copy link
Contributor Author

@sorousht

An if you check the logs you can find this line the reason of failing tests

Cannot find module '@babel/compat-data/corejs3-shipped-proposals'

It's the reason of failing all tests!

@hosseinAMD
Copy link
Contributor Author

OK it solved with fetching upstream repository Finally! :)
Thanks @sorousht for your efforts

Copy link
Collaborator

@sorousht sorousht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hosseinAMD عزیز

ترجمه دقیق و با کیفیتی بود! پیشنهاداتی که دادم بیشتر نگارشی هستند. ممنون از شما

ارادتمند، سروش

content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
hosseinAMD and others added 17 commits June 25, 2020 13:04
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
hosseinAMD and others added 17 commits June 25, 2020 13:13
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
Co-authored-by: Soroush Torkzadeh <soroush.torkzadeh@gmail.com>
@hosseinAMD hosseinAMD requested a review from sorousht June 25, 2020 09:12
@sorousht sorousht merged commit a02fb4e into reactjs:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants