Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React without ES6 translated #179

Merged
merged 1 commit into from
Nov 22, 2020

Conversation

hosseinAMD
Copy link
Contributor

Dear @sorousht

Take your time to review this page!
Good luck!

@netlify
Copy link

netlify bot commented Nov 8, 2020

Deploy preview for fa-reactjs failed.

Built with commit b05ccea

https://app.netlify.com/sites/fa-reactjs/deploys/5fa7959a212a770008811dce

@hosseinAMD
Copy link
Contributor Author

hosseinAMD commented Nov 8, 2020

@sorousht
I can't understand the problem of tests failing.
I've done steps like other pages and only translated .md file
Can you check why the tests are failing?

Steps

git fetch upstream
git merge upstream/master
git checkout -b [branch-name]
git status
git add .
git commit -m "message"
git push origin [branch-name]

Copy link
Collaborator

@sorousht sorousht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

مثل همیشه عالی بود @hosseinAMD جان!

@sorousht
Copy link
Collaborator

بررسی می کنم ببینم مشکل از چیه!

@sorousht sorousht merged commit ee64768 into reactjs:master Nov 22, 2020
@sorousht
Copy link
Collaborator

پول ریکوست قبول و ادغام شد!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants