Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate page "Rendering Elements" #28

Merged
merged 25 commits into from
Mar 7, 2019

Conversation

sorousht
Copy link
Collaborator

@sorousht sorousht commented Mar 1, 2019

No description provided.

@sorousht sorousht added the translation A new page has been translated label Mar 1, 2019
@netlify
Copy link

netlify bot commented Mar 1, 2019

Deploy preview for fa-reactjs ready!

Built with commit b06a454

https://deploy-preview-28--fa-reactjs.netlify.com

content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
sJJdGG and others added 5 commits March 3, 2019 14:29
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Use a batter word for **Note**

Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
@sorousht sorousht requested a review from sJJdGG March 3, 2019 11:12
zahrajoulaei
zahrajoulaei previously approved these changes Mar 4, 2019
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
Copy link
Member

@sJJdGG sJJdGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorousht If you find some changes unnecessary let me know

content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
Thanks to @sJJdGG

Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
sJJdGG and others added 5 commits March 4, 2019 14:21
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Thanks to @sJJdGG

Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
sJJdGG and others added 7 commits March 4, 2019 19:15
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
…ring-elements.md

Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
@sorousht sorousht requested a review from sJJdGG March 5, 2019 13:18
Copy link
Member

@sJJdGG sJJdGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Render is more of a verb that does something and is a synonym of verb "make" and it'd better be translated to "رندر کردن" instead of "رندر شدن". "being rendered" is the one that should be translated to "رندر شدن". Or at least that's what I think.

@sorousht @zahrajoulaei What do you think?

content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
Copy link
Member

@sJJdGG sJJdGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sorousht Some final minor enhancements I could think of. Let me know what you think.

content/docs/rendering-elements.md Outdated Show resolved Hide resolved
content/docs/rendering-elements.md Outdated Show resolved Hide resolved
sJJdGG and others added 4 commits March 6, 2019 12:04
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
@sorousht
Copy link
Collaborator Author

sorousht commented Mar 6, 2019

Render is more of a verb that does something and is a synonym of verb "make" and it'd better be translated to "رندر کردن" instead of "رندر شدن". "being rendered" is the one that should be translated to "رندر شدن". Or at least that's what I think.

@sorousht @zahrajoulaei What do you think?

Yeah, your right.
"رندر شدن" means "being rendered" and,
"رندر کردن" means "rendering".

So I fix that.

@sorousht sorousht requested a review from sJJdGG March 6, 2019 08:45
Copy link
Member

@sJJdGG sJJdGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems completely ok except this minor word placement

content/docs/rendering-elements.md Outdated Show resolved Hide resolved
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
@sJJdGG sJJdGG self-requested a review March 7, 2019 10:51
Copy link
Member

@sJJdGG sJJdGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sJJdGG sJJdGG merged commit 9daceec into reactjs:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation A new page has been translated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants