Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate hello-world.md #38

Merged
merged 13 commits into from
Mar 29, 2019
Merged

Translate hello-world.md #38

merged 13 commits into from
Mar 29, 2019

Conversation

sorousht
Copy link
Collaborator

No description provided.

@sorousht sorousht added the translation A new page has been translated label Mar 21, 2019
@netlify
Copy link

netlify bot commented Mar 21, 2019

Deploy preview for fa-reactjs ready!

Built with commit 7df35ef

https://deploy-preview-38--fa-reactjs.netlify.com

content/docs/hello-world.md Outdated Show resolved Hide resolved
zahrajoulaei
zahrajoulaei previously approved these changes Mar 24, 2019
Copy link
Member

@sJJdGG sJJdGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you find some changes unnecessary or partially necessary.

content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
content/docs/hello-world.md Outdated Show resolved Hide resolved
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
sJJdGG and others added 10 commits March 27, 2019 19:15
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
@sorousht
Copy link
Collaborator Author

@sJJdGG I really appreciate the time you took to review my work precisely and always get surprised by the number of errors you find :))

@sJJdGG
Copy link
Member

sJJdGG commented Mar 29, 2019

@sorousht Thanks. Just doing my part.

@sJJdGG sJJdGG self-requested a review March 29, 2019 08:11
Copy link
Member

@sJJdGG sJJdGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sorousht sorousht merged commit 982a2d2 into reactjs:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation A new page has been translated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants