Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditional-rendering #64

Merged
merged 19 commits into from
Dec 15, 2019

Conversation

sorousht
Copy link
Collaborator

This PR completes the translation of @black-sheep777 (#47)

blacksheepIV and others added 5 commits April 10, 2019 15:37
The added words are based on the recent discussions on issue#41
…7/fa.reactjs.org into black-sheep777-ConditionalRendering
The PR was left for 30 days and I decided to apply the changes
and merge it inorder to prevent it from decaying
@netlify
Copy link

netlify bot commented May 10, 2019

Deploy preview for fa-reactjs ready!

Built with commit 6885094

https://deploy-preview-64--fa-reactjs.netlify.com

sJJdGG
sJJdGG previously requested changes Jun 3, 2019
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
@@ -36,21 +36,21 @@ function Greeting(props) {
}

ReactDOM.render(
// Try changing to isLoggedIn={true}:
// تغییر isLoggedIn={true} را امتحان کنید
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

توی خروجی سایت این بخش بد نشون داده میشه که به نظرم مربوط به موتور رندر markdown میشه که گتسبی استفاده میکنه. نیاز به یه خرده تحقیق بیشتر داره که راه حلش رو توی گتسبی پیدا کنیم و این مشکل رو یه بار برای همیشه برای همه کامنت های توی کد حل کنیم. خودم هم در اولین فرصت روش کار میکنم.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sJJdGG آره این مشکل آزار دهنده هست توی کد‌ها و خیلی خوب میشه اگه حل بشه

content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
@blacksheepIV
Copy link
Contributor

@sorousht I appreciate your help. I'm kinda new to this PR thing, should I wait for the 3rd reviewer or proceed with changing the translation & making a new PR?

@sorousht
Copy link
Collaborator Author

@black-sheep777 You did not show up since you submitted your PR #47. So I had to close that and opened a new one in order to continue your translation. Now It's almost done. If you have any comment on this page, please leave your comments here, otherwise, if you are interested in translating another page, write a comment on issue #1, then I will assign the desired page to you.

sorousht and others added 14 commits June 16, 2019 15:43
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
…usht/fa.reactjs.org into black-sheep777-ConditionalRendering
@sorousht sorousht requested a review from sJJdGG June 16, 2019 14:20
@sorousht sorousht removed the request for review from sJJdGG October 4, 2019 13:35
Copy link
Collaborator

@seven-deuce seven-deuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for merge

@sorousht sorousht dismissed sJJdGG’s stale review December 15, 2019 18:27

Waiting so long to be approved

@sorousht sorousht merged commit e16a18a into reactjs:master Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants