-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conditional-rendering #64
conditional-rendering #64
Conversation
The added words are based on the recent discussions on issue#41
…7/fa.reactjs.org into black-sheep777-ConditionalRendering
The PR was left for 30 days and I decided to apply the changes and merge it inorder to prevent it from decaying
…-sheep777-ConditionalRendering
Deploy preview for fa-reactjs ready! Built with commit 6885094 |
@@ -36,21 +36,21 @@ function Greeting(props) { | |||
} | |||
|
|||
ReactDOM.render( | |||
// Try changing to isLoggedIn={true}: | |||
// تغییر isLoggedIn={true} را امتحان کنید |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
توی خروجی سایت این بخش بد نشون داده میشه که به نظرم مربوط به موتور رندر markdown میشه که گتسبی استفاده میکنه. نیاز به یه خرده تحقیق بیشتر داره که راه حلش رو توی گتسبی پیدا کنیم و این مشکل رو یه بار برای همیشه برای همه کامنت های توی کد حل کنیم. خودم هم در اولین فرصت روش کار میکنم.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sJJdGG آره این مشکل آزار دهنده هست توی کدها و خیلی خوب میشه اگه حل بشه
@sorousht I appreciate your help. I'm kinda new to this PR thing, should I wait for the 3rd reviewer or proceed with changing the translation & making a new PR? |
@black-sheep777 You did not show up since you submitted your PR #47. So I had to close that and opened a new one in order to continue your translation. Now It's almost done. If you have any comment on this page, please leave your comments here, otherwise, if you are interested in translating another page, write a comment on issue #1, then I will assign the desired page to you. |
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
…usht/fa.reactjs.org into black-sheep777-ConditionalRendering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved for merge
This PR completes the translation of @black-sheep777 (#47)