Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict mode #118

Closed
wants to merge 5 commits into from
Closed

Strict mode #118

wants to merge 5 commits into from

Conversation

sheplu
Copy link
Collaborator

@sheplu sheplu commented Mar 20, 2019

No description provided.

@netlify
Copy link

netlify bot commented Mar 20, 2019

Deploy preview for fr-reactjs ready!

Built with commit 6c8f467

https://deploy-preview-118--fr-reactjs.netlify.com

@sheplu sheplu requested a review from tdd March 20, 2019 10:30
@sheplu sheplu added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Mar 20, 2019
@tdd tdd self-assigned this Mar 20, 2019
Copy link
Collaborator Author

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
@tdd
Copy link
Collaborator

tdd commented Mar 20, 2019

@sheplu j'apprécie ton effort mais tu as complètement tué la branche d'origine de la PR d'@erkela, donc effacé l'attribution de son travail… Pas cool 😒. La méthodologie que je t'avais donné aurait dû te permettre de créer ta propre branche sur base de son historique de commits à lui, pour appliquer ensuite manuellement les modifs.

@tdd
Copy link
Collaborator

tdd commented Mar 20, 2019

@sheplu du coup je me sers de ton fichier final pour ma repasse locale finale, et je pondrai une 3e et dernière PR qui restitue les attributions correctes (dont la tienne) pour être tranquille.

@tdd
Copy link
Collaborator

tdd commented Mar 20, 2019

Superseded by #121

@tdd tdd closed this Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants