Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate shallow renderer screen title and intro #28

Merged
merged 19 commits into from
Feb 28, 2019
Merged

translate shallow renderer screen title and intro #28

merged 19 commits into from
Feb 28, 2019

Conversation

mikaoelitiana
Copy link
Contributor

@mikaoelitiana mikaoelitiana commented Feb 13, 2019 •
edited
Loading

Traduction de la page shallow renderer

  • titre
  • intro
  • explications
  • références

@mikaoelitiana mikaoelitiana changed the title [WIP] translate shallow renderer screen title and intro translate shallow renderer screen title and intro Feb 13, 2019
@tdd tdd self-requested a review February 13, 2019 21:33
@tdd tdd self-assigned this Feb 13, 2019
@tdd tdd added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Feb 13, 2019
@tesseralis tesseralis mentioned this pull request Feb 13, 2019
Closed
gkueny
gkueny suggested changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@gkueny gkueny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋🏻

Je me suis permis de proposer quelques modifications, essentiellement sur les guillemet français et des typo

content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
gkueny and others added 4 commits February 14, 2019 14:15
@gkueny @mikaoelitiana
Update content/docs/addons-shallow-renderer.md
d2eb430 
fix quote

Co-Authored-By: mikaoelitiana <mikaoelitiana@users.noreply.github.com>
@gkueny @mikaoelitiana
Update content/docs/addons-shallow-renderer.md
45dddc1 
fix recommend for french

Co-Authored-By: mikaoelitiana <mikaoelitiana@users.noreply.github.com>
@gkueny @mikaoelitiana
Update content/docs/addons-shallow-renderer.md
3e4ba29 
fix "appelé"

Co-Authored-By: mikaoelitiana <mikaoelitiana@users.noreply.github.com>
@gkueny @mikaoelitiana
Update content/docs/addons-shallow-renderer.md
8c6a4a3 
fix quote and verb

Co-Authored-By: mikaoelitiana <mikaoelitiana@users.noreply.github.com>
@mikaoelitiana
Copy link
Contributor Author

@gkueny merci pour ces corrections

JeremiePat
JeremiePat requested changes Feb 18, 2019
View reviewed changes
Copy link
Collaborator

@JeremiePat JeremiePat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, merci pour cette traduction. Je me suis permis de faire quelques suggestions de changement pour alléger le style rédactionnel, mais rien à dire sur le fond. Je te laisse faire les quelques changement nécessaire (soit toi même, soit en acceptant les suggestions).

content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
@JeremiePat JeremiePat added Reviewed and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels Feb 18, 2019
JeremiePat and others added 9 commits February 18, 2019 18:16
@JeremiePat @mikaoelitiana
Update content/docs/addons-shallow-renderer.md
e158165 
Co-Authored-By: mikaoelitiana <mikaoelitiana@users.noreply.github.com>
@JeremiePat @mikaoelitiana
Update content/docs/addons-shallow-renderer.md
d1621fc 
Co-Authored-By: mikaoelitiana <mikaoelitiana@users.noreply.github.com>
@JeremiePat @mikaoelitiana
Update content/docs/addons-shallow-renderer.md
49787e5 
Co-Authored-By: mikaoelitiana <mikaoelitiana@users.noreply.github.com>
@JeremiePat @mikaoelitiana
Update content/docs/addons-shallow-renderer.md
67342f0 
Co-Authored-By: mikaoelitiana <mikaoelitiana@users.noreply.github.com>
@JeremiePat @mikaoelitiana
Update content/docs/addons-shallow-renderer.md
4726fb2 
Co-Authored-By: mikaoelitiana <mikaoelitiana@users.noreply.github.com>
@JeremiePat @mikaoelitiana
Update content/docs/addons-shallow-renderer.md
43a3a06 
Co-Authored-By: mikaoelitiana <mikaoelitiana@users.noreply.github.com>
@JeremiePat @mikaoelitiana
Update content/docs/addons-shallow-renderer.md
3349dd2 
Co-Authored-By: mikaoelitiana <mikaoelitiana@users.noreply.github.com>
@JeremiePat @mikaoelitiana
Update content/docs/addons-shallow-renderer.md
f78d5fa 
Co-Authored-By: mikaoelitiana <mikaoelitiana@users.noreply.github.com>
@JeremiePat @mikaoelitiana
Update content/docs/addons-shallow-renderer.md
a6e0cb8 
Co-Authored-By: mikaoelitiana <mikaoelitiana@users.noreply.github.com>
@mikaoelitiana
Copy link
Contributor Author

@JeremiePat Merci pour ces suggestions, je les ai intégrées

@JeremiePat
Copy link
Collaborator

De rien, je laisse @tdd faire une dernière passe et merger :)

@netlify
Copy link

netlify bot commented Feb 25, 2019 •
edited
Loading

Deploy preview for fr-reactjs ready!

Built with commit abb1dc6

https://deploy-preview-28--fr-reactjs.netlify.com

@tdd tdd added Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels Feb 27, 2019
tdd
tdd requested changes Feb 28, 2019
View reviewed changes
Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @mikaoelitiana !

Avant toute chose, merci pour tout ce boulot ! C'est super cool de nous filer un coup de main.

C’est globalement très bien, j'ai juste homogénéisé par rapport aux autres pages API traduites, et corrigé quelques petits trucs, mais pas de gros glissement sémantique ni trop de formules pataudes, GG ! 👏

Tout est fait sous forme de Suggestions GitHub, il te suffit à chaque suggestion que tu approuves de cliquer le bouton d'ajout au lot de modifs à committer, et sur la fin de créer le commit groupé. (ce mode de regroupement en un seul commit est à favoriser absolument, mais tu devras aller dans l'onglet Files changed pour y accéder, il n'est pas utilisable dans l’onglet Conversation)

Si certaines appellent discussion, n'hésite pas, tu réponds, on en parle, on avance ensemble 🤝

Quand tout sera bouclé côté code, je ferai une repasse visuelle finale en local avant de fusionner.

Encore mille mercis, j'ai hâte de voir cette PR finalisée et dans master !

content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md

```javascript
import ShallowRenderer from 'react-test-renderer/shallow';

// in your test:
// dans votre test :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste au-dessous, tu as oublié de retraduire le littéral « Titre » dans la grappe de test.

content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
@tdd tdd removed the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Feb 28, 2019
tdd and others added 2 commits February 28, 2019 17:17
@tdd @mikaoelitiana
Apply suggestions from code review
806a9d7 
Co-Authored-By: mikaoelitiana <mikaoelitiana@users.noreply.github.com>
@mikaoelitiana
replace Title => Titre
a1e0c11
@mikaoelitiana
Copy link
Contributor Author

@tdd merci pour les commentaires et les suggestions. J'ai accepté les modifications.

@tdd tdd merged commit a6e4f09 into reactjs:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkueny gkueny gkueny requested changes

@JeremiePat JeremiePat JeremiePat approved these changes

@tdd tdd tdd approved these changes

Assignees

@tdd tdd

Labels
Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikaoelitiana @JeremiePat @tdd @gkueny