Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐translation page faq-styling #56

Merged
merged 6 commits into from
Mar 12, 2019
Merged

Conversation

lbelavoir
Copy link
Contributor

Bonjour,

Voici la traduction de FAQ - Styles and CSS.

J'ai une hésitation à traduire ou non React Transition Group et React Motion.

@Nab69 Nab69 added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Feb 20, 2019
Copy link
Collaborator

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour moi ca me semble bon de laisser les mots anglais pour Motion et Groupe

content/docs/faq-styling.md Outdated Show resolved Hide resolved
content/docs/faq-styling.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Feb 24, 2019

Deploy preview for fr-reactjs ready!

Built with commit 7f8d775

https://deploy-preview-56--fr-reactjs.netlify.com

@tdd tdd self-assigned this Mar 8, 2019
Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @lbelavoir !

Avant toute chose, merci pour tout ce boulot ! C'est super cool de nous filer un coup de main.

On est ici surtout sur de petites retouches cosmétiques, plus une ou deux reformulations, rien de méchant, c'était plutôt pas mal du tout à la base 😎

Tout est fait sous forme de Suggestions GitHub, il te suffit à chaque suggestion que tu approuves de cliquer le bouton d'ajout au lot de modifs à committer, et sur la fin de créer le commit groupé. (ce mode de regroupement en un seul commit est à favoriser absolument, mais tu devras aller dans l'onglet Files changed pour y accéder, il n'est pas utilisable dans l’onglet Conversation)

Si certaines appellent discussion, n'hésite pas, tu réponds, on en parle, on avance ensemble 🤝

Quand tout sera bouclé côté code, je ferai une repasse visuelle finale en local avant de fusionner.

Encore mille mercis, j'ai hâte de voir cette PR finalisée et dans master !

content/docs/faq-styling.md Outdated Show resolved Hide resolved
content/docs/faq-styling.md Outdated Show resolved Hide resolved
content/docs/faq-styling.md Outdated Show resolved Hide resolved
content/docs/faq-styling.md Outdated Show resolved Hide resolved
content/docs/faq-styling.md Outdated Show resolved Hide resolved
content/docs/faq-styling.md Outdated Show resolved Hide resolved
content/docs/faq-styling.md Outdated Show resolved Hide resolved
content/docs/faq-styling.md Outdated Show resolved Hide resolved
content/docs/faq-styling.md Outdated Show resolved Hide resolved
content/docs/faq-styling.md Outdated Show resolved Hide resolved
@tdd tdd added Reviewed and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels Mar 11, 2019
Co-Authored-By: lbelavoir <lbelavoir@users.noreply.github.com>
@tdd tdd merged commit 21b697a into reactjs:master Mar 12, 2019
@lbelavoir lbelavoir deleted the faq-styling branch March 13, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants