Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating with other libraries #80

Merged
merged 8 commits into from
Mar 13, 2019

Conversation

lbelavoir
Copy link
Contributor

Une hésitation sur la traduction de unregister en désenregistrer ?

@netlify
Copy link

netlify bot commented Mar 2, 2019

Deploy preview for fr-reactjs ready!

Built with commit b84e2ce

https://deploy-preview-80--fr-reactjs.netlify.com

@lbelavoir lbelavoir marked this pull request as ready for review March 3, 2019 18:37
@tdd tdd added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Mar 4, 2019
@JeremiePat JeremiePat added the Reviewing Un mainteneur qualifié est en train de composer la revue de code label Mar 8, 2019
@JeremiePat JeremiePat self-requested a review March 8, 2019 13:06
@tdd tdd self-assigned this Mar 8, 2019
Copy link
Collaborator

@JeremiePat JeremiePat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @lbelavoir

Excellente traduction une fois de plus :) Quelques petite suggestions de modifications en attendant la revus de @tdd :)

content/blog/2015-03-30-community-roundup-26.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
@JeremiePat JeremiePat added Reviewed and removed Reviewing Un mainteneur qualifié est en train de composer la revue de code labels Mar 8, 2019
JeremiePat and others added 2 commits March 10, 2019 15:43
Co-Authored-By: lbelavoir <lbelavoir@users.noreply.github.com>
Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @lbelavoir !

Avant toute chose, merci pour tout ce boulot ! C'est super cool de nous filer un coup de main.

Très bien comme toujours, pas mal de petites retouches sur ton usage à tout crin de rendu/rendre/rend, pourtant interdit/découragé par le Glossaire, un ou deux petits glissements sémantiques, et sinon surtout de la typographie / des retouches de détail.

Tout est fait sous forme de Suggestions GitHub, il te suffit à chaque suggestion que tu approuves de cliquer le bouton d'ajout au lot de modifs à committer, et sur la fin de créer le commit groupé. (ce mode de regroupement en un seul commit est à favoriser absolument, mais tu devras aller dans l'onglet Files changed pour y accéder, il n'est pas utilisable dans l’onglet Conversation)

Si certaines appellent discussion, n'hésite pas, tu réponds, on en parle, on avance ensemble 🤝

Quand tout sera bouclé côté code, je ferai une repasse visuelle finale en local avant de fusionner.

Encore mille mercis, j'ai hâte de voir cette PR finalisée et dans master !

content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
content/docs/integrating-with-other-libraries.md Outdated Show resolved Hide resolved
@tdd tdd removed the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Mar 12, 2019
Co-Authored-By: lbelavoir <lbelavoir@users.noreply.github.com>
@tdd tdd merged commit f13c300 into reactjs:master Mar 13, 2019
@lbelavoir lbelavoir deleted the integrating-with-other-libraries branch March 13, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants