Skip to content

feat: Translate Conditional Rendering #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nirmitkotadiya
Copy link
Contributor

@nirmitkotadiya nirmitkotadiya commented Apr 13, 2025

📝 Description

This PR adds the official Gujarati translation for the "Conditional Rendering" page from the React documentation. The content has been carefully translated to retain its original meaning, technical accuracy, and readability for Gujarati-speaking developers.

✅ Checklist

  • Page fully translated
  • Checked for grammar, clarity, and developer tone
  • Verified formatting and links
  • Screenshots added for translated UI

📷 Screenshots

Screenshot 2025-04-13 164321
Screenshot 2025-04-13 164353
Screenshot 2025-04-13 164412

🔗 Linked Issue

References #[issue-number]](#1 (comment))

🧪 How to check?

Deployment preview : https://gu-react-7uudurjb1-fbopensource.vercel.app/learn/conditional-rendering

@harshilparmar
Copy link
Collaborator

Thanks @nirmitkotadiya I will review it in this week.

@harshilparmar
Copy link
Collaborator

Have you looked into this section for the following guidelines?

@nirmitkotadiya
Copy link
Contributor Author

Yes, I’ve already reviewed this section. I’ll recheck it if any issues are found.

@nirmitkotadiya
Copy link
Contributor Author

Could you please clarify what the issue is in this PR? I've already checked it twice.

@harshilparmar
Copy link
Collaborator

Could you please clarify what the issue is in this PR? I've already checked it twice.

I was waiting for your reply. I will take a look and let you know. Thanks.

Copy link
Collaborator

@harshilparmar harshilparmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please incorporate these changes?

@nirmitkotadiya
Copy link
Contributor Author

nirmitkotadiya commented May 15, 2025

Hello @harshilparmar, all changes have been completed from my side. Please review and merge.
Commit ID: 4694c1e

@harshilparmar
Copy link
Collaborator

@nirmitkotadiya It seems like you have replaced all the * with _. I hope you are running yarn check-all after making changes locally. Please ensure that your changes don't disrupt the current build process.

Copy link

github-actions bot commented May 15, 2025

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@nirmitkotadiya
Copy link
Contributor Author

@harshilparmar I intended to run the check, but encountered a Prettier error. So I applied the changes manually—please review them.

@harshilparmar
Copy link
Collaborator

harshilparmar commented May 16, 2025

Can you please check why it shows a red cross besides your commit?
Screenshot 2025-05-15 at 11 13 04 PM

@nirmitkotadiya nirmitkotadiya requested a review from mkcindia May 16, 2025 04:23
nirmitkotadiya

This comment was marked as resolved.

@nirmitkotadiya
Copy link
Contributor Author

@harshilparmar How can this issue be resolved?

image
image

@harshilparmar
Copy link
Collaborator

@nirmitkotadiya, I would like to ask you to have some patience and not to do anything that is not standard for this official repo. Give me some time, I will look into this.
Screenshot 2025-05-16 at 7 40 44 AM

@harshilparmar harshilparmar removed the request for review from mkcindia May 16, 2025 11:45
@nirmitkotadiya
Copy link
Contributor Author

Okay, I will wait. This was a mistake on my part, and I’ll make sure it doesn’t happen again in the future.

@harshilparmar
Copy link
Collaborator

I'm merging this PR into main after considering that Vercel authorization has some issues for generating a new preview link.

@harshilparmar harshilparmar merged commit 3c19bfc into reactjs:main Jul 6, 2025
2 of 3 checks passed
@nirmitkotadiya
Copy link
Contributor Author

Thanks for merging the PR!
Kindly tick the Conditional Rendering issue (@nirmitkotadiya) as it has been successfully merged.

@harshilparmar
Copy link
Collaborator

I figured out the issue. For your information, it happened because you tried to commit directly into the main branch. I assume you forgot to pull the latest main changes while incorporating PR reviews' changes.

However, to maintain a clean git history, I had to remove those commits from the main branch. I would appreciate it if you could make a new small pr for those last changes.

Please make sure to sync your fork with the latest main changes.

Main branch history before:
Screenshot 2025-07-06 at 8 33 53 PM

@nirmitkotadiya
Copy link
Contributor Author

Hello @harshilparmar,

As per your request, I’ve created a new PR with the necessary changes.
Please review it, and if any further updates are required, feel free to let me know.

PR Link: #103 – Translate Conditional Rendering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants