Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated till line 251 #210

Closed
wants to merge 1 commit into from
Closed

Translated till line 251 #210

wants to merge 1 commit into from

Conversation

lucifertrj
Copy link
Contributor

Hi @arshadkazmi42,

I had forgotten entirely about my assigned task to translate rendering lists.md. I have translated rendering-lists.md till line 250, waiting for review and feedback to proceed with the further translation.

Kind regards,

@github-actions
Copy link

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/learn/rendering-lists 62.56 KB (🟡 +844 B) 157.79 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@arshadkazmi42
Copy link
Member

Hi @lucifertrj

Thank you for sending PR. I will suggest translating the whole file, then we can start the review process as we have faced issues before when we were working on partial translations and review.

We try to translate the whole file in a go and then we review the translation in parts.

You can let me know once the translation of whole file is completed, post that I can start the review.

@lucifertrj
Copy link
Contributor Author

to translate the whole file in

Sure

@arshadkazmi42 arshadkazmi42 self-requested a review August 13, 2022 17:17
@arshadkazmi42 arshadkazmi42 added 1st Review First phase of review and removed 1st Review First phase of review labels Aug 13, 2022
Copy link

@yogesharma12 yogesharma12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lucifertrj
I have a suggestion . Please keep some keywords in English Itself . Like Array and the function Recipeलिस्ट could have been RecipeList only.
and घटक could be कंपोनेंट

@arshadkazmi42
Copy link
Member

arshadkazmi42 commented Aug 22, 2022

Hi @lucifertrj I have a suggestion . Please keep some keywords in English Itself . Like Array and the function Recipeलिस्ट could have been RecipeList only. and घटक could be कंपोनेंट

Thank you for pointing that out @yogesharma12
Just to add to that for component we use कौम्पोनॅन्ट

For similar words are available here for reference #2

@lucifertrj lucifertrj closed this by deleting the head repository Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants