Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation for "Sharing State Between Components" #212

Merged
merged 10 commits into from
Oct 11, 2022

Conversation

BryanRonad
Copy link
Contributor

@BryanRonad BryanRonad commented Aug 27, 2022

Translating the Sharing State Between Components page to Hindi.
Related to #168
Review progress

  • Overview
  • Lifting state up by example
    • Step 1: Remove state from the child components
    • Step 2: Pass hardcoded data from the common parent
    • Step 3: Add state to the common parent
  • A single source of truth for each state
  • Recap
  • Challenges

@github-actions github-actions bot added the beta label Aug 27, 2022
@BryanRonad BryanRonad changed the title Update sharing-state-between-components.md Translation for "Sharing State Between Components" Aug 27, 2022
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

Added review till line 88.

Let's get this fixed, post that we can continue on further review.

To know more about our review process, refer #23

beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on the fixes.

I have added more reviews till line 131.

Lets get these fixed and then we will continue further with the review

beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

I have added some more comments till line 274.

Let's work on getting these fixed and post that we can continue further with the review.

beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
@arshadkazmi42
Copy link
Member

@BryanRonad You have missed one review suggestion, can you fix that? Post that we can continue further

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with the fixes.

I have added review for the rest of the changes. Once these are fixed, we can get this merged.

beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

I just added few comments for the alt text you have translated, lets get these fixed and there is one pending comment from previous review which is not resolved.

Once these are fixed we will get this merged.

beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
beta/src/pages/learn/sharing-state-between-components.md Outdated Show resolved Hide resolved
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with this and thank you for working on all the reviews.

Let's get this merged 🎉

@github-actions
Copy link

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/learn/sharing-state-between-components 61.92 KB (🟡 +2.12 KB) 157.14 KB
/learn/state-a-components-memory 64.88 KB (🟢 -3.48 KB) 160.11 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@arshadkazmi42 arshadkazmi42 merged commit 31f992d into reactjs:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st Review First phase of review beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants