Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated Lists-and-Keys page #25

Merged
merged 29 commits into from
Jun 3, 2019

Conversation

aliana17
Copy link
Contributor

@aliana17 aliana17 commented Mar 21, 2019

  • कई कौम्पोनॅन्टस को रेंडर करना
  • मूल लिस्टस कौम्पोनॅन्ट
  • Keys
  • key के साथ कंपोनेंट्स निकालना
  • keys सिर्फ़ भाई-बहनों के बीच अद्वितीय होनी चाहिए
  • JSX में मैप की एम्बेडिंग

@netlify
Copy link

netlify bot commented Mar 21, 2019

Deploy preview for hi-reactjs ready!

Built with commit 730d233

https://deploy-preview-25--hi-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Mar 21, 2019

Deploy preview for hi-reactjs ready!

Built with commit 9e277a7

https://deploy-preview-25--hi-reactjs.netlify.com

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.
I have started the review.
I have added the feedback till line 100. Once you are done fixing those, we can continue with a review of the next parts of the translation.

Please do go through the review process (here #23) which we follow.
You can make the suggested changes and add an 👍 emoji to acknowledge it, the reviewer will review the changes and they will resolve the feedback

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
@arshadkazmi42
Copy link
Member

@anchal7299 Any updates on this, let us know if you need any help from our end with the translation

@aliana17
Copy link
Contributor Author

aliana17 commented Mar 27, 2019 via email

@arshadkazmi42
Copy link
Member

@anchal7299 Great work, there is some more comments I have added in the same feedback.
Can you have a look at the feedbacks which are not resolved.
Also mark every feedback with 👍 emoji, once you have fixed it, so it will be easy for us during review.
Once you are done with these changes, I will start review of rest of the translation

@aliana17
Copy link
Contributor Author

aliana17 commented Mar 28, 2019 via email

@arshadkazmi42
Copy link
Member

@anchal7299 Great going, there are few more changes which broke during other changes, once you are done with those changes I can start reviewing reset of the translation

@arshadkazmi42
Copy link
Member

@anchal7299 There is only 1 change pending for this review, then I will start with next part of the translation review

@aliana17
Copy link
Contributor Author

aliana17 commented Apr 8, 2019 via email

@arshadkazmi42
Copy link
Member

Are you using Windows?

Can you try this
https://stackoverflow.com/a/36421510/3136282

@aliana17
Copy link
Contributor Author

aliana17 commented Apr 11, 2019 via email

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work till now and thank you for your patience with the feedback implementation.
I have added a couple of more feedbacks, once these are fixed it will be good to go from my end.

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
content/docs/lists-and-keys.md Outdated Show resolved Hide resolved
@saranshkataria
Copy link
Member

done till line 100

@saranshkataria
Copy link
Member

done till {#extracting-components-with-keys}


Keys only make sense in the context of the surrounding array.
Keys केवल उनके array के लिए ही होती है।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect translation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not getting it's correct translation . Please suggest it's hindi translation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keys केवल आस-पास के array के संदर्भ में ही समझ में आती हैं।

@saranshkataria
Copy link
Member

done till {#embedding-map-in-jsx}

@saranshkataria
Copy link
Member

Awesome work @anchal7299 ! Thank you! And merging this in.

@saranshkataria saranshkataria merged commit 2df0e31 into reactjs:master Jun 3, 2019
@aliana17
Copy link
Contributor Author

aliana17 commented Jun 4, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants