Translating page Style and Lifecycle. #26

charBap · 2019-03-21T20:50:30Z

This pull request is in reference to translating "Style and Lifcycle" page.
#1

Style and Lifecycle
किसी फंक्शन को क्लास में बदलना
क्लास में स्थानीय state जोड़ना
क्लास में जीवनचक्र की विधियाँ जोड़ना
सही ढंग से state का उपयोग करना
State अपडेट्स असिंक्रोनस हो सकते हैं
डेटा नीचे बहती है

netlify · 2019-03-21T20:55:29Z

Deploy preview for hi-reactjs ready!

Built with commit c364000

https://deploy-preview-26--hi-reactjs.netlify.com

arshadkazmi42

This is great start
I have started the review.
I have added the feedback till line 60.
Once you are done fixing those, we can continue with a review of the next parts of the translation.

Please do go through the review process (here #23) which we follow.
You can make the suggested changes and add an 👍 emoji to acknowledge it, the reviewer will review the changes and they will resolve the feedback

content/docs/state-and-lifecycle.md

1. राज्य => State 2. प्रतिक्रिया => React 3. घटक => कौम्पोनॅन्ट

arshadkazmi42 · 2019-03-22T03:23:19Z

@charBap Can you also, mark the review feedback which you have fixed using 👍 emoji

arshadkazmi42 · 2019-03-22T03:24:24Z

@charBap Do not resolve the feedbacks, reviewer will resolve it.
Read our review process here #23
Please read my feedback review also once.

arshadkazmi42 · 2019-03-22T03:49:52Z

@charBap Please read the comments I have been adding, it will be difficult to review if you are not reading my comments.
"Do not resolve the feedbacks." Reviewer will resolve it after verifying.
Which ever feedbacks are fixed add a 👍 emoji in the comments of that feedback

charBap · 2019-03-22T03:52:22Z

@arshadkazmi42 I have resolved all issues that you have specified.

charBap · 2019-03-22T03:53:18Z

@arshadkazmi42 Sorry my bad.

arshadkazmi42 · 2019-03-22T03:53:20Z

@charBap Do not mark them resolved, just add a 👍 in the comments.
Once you are done marking 👍 to all the feedbacks, I will start reviewing your changes

arshadkazmi42 · 2019-03-22T03:54:16Z

It's just to follow a procedure, it will be easy for reviewers to keep track of the review if everyone follows the process

arshadkazmi42 · 2019-03-22T04:04:11Z

@charBap All changes looks fine. There is just a small issue you missed, I have left a comment for that and resolved all other conversations.
Once you update that, I will start reviewing the next parts of the translation

arshadkazmi42

Great work till now.
Added few more comments, done till line 109

content/docs/state-and-lifecycle.md

arshadkazmi42 · 2019-03-23T02:54:09Z

@charBap There are many feedback which are not acknowledged, can you have a look at those too

charBap · 2019-03-23T03:01:49Z

@arshadkazmi42 I am doing it right now. :)

arshadkazmi42 · 2019-03-23T05:28:26Z

@charBap There is 1 issue at line 75-76, once that is fixed, I will continue with next lines review

arshadkazmi42

Great work.
Added some more comments.
Done till line 250

content/docs/state-and-lifecycle.md

arshadkazmi42 · 2019-03-26T03:23:08Z

@charBap I have resolved most of the feedbacks, there is a couple of feedbacks which I missed in my previous review, I have added comments for those, once you are done with those we can move ahead with the review process.

arshadkazmi42 · 2019-03-26T06:59:14Z

@charBap There is one more fix pending.

saranshkataria · 2019-03-28T22:25:29Z

content/docs/state-and-lifecycle.md


-The `render` method will be called each time an update happens, but as long as we render `<Clock />` into the same DOM node, only a single instance of the `Clock` class will be used. This lets us use additional features such as local state and lifecycle methods.
+हर अपडेट पर `render` फंक्शन कॉल होगा, लेकिन जब तक हम `<Clock />` को एक ही DOM नोड में रेंडर करते हैं, तब तक `Clock` क्लास का केवल एक ही उदाहरण इस्तेमाल किया जाएगा। इससे हम लोकल state और Lifecycle विधियों जैसी अतिरिक्त सुविधाओं का उपयोग कर सकते हैं।


उदाहरण -> incorrect translation

दृष्टांत -> what?

Can you please suggest then what should go there. (Please specify in hindi)

content/docs/state-and-lifecycle.md

saranshkataria · 2019-03-28T22:26:17Z

done till {#adding-local-state-to-a-class}

saranshkataria · 2019-04-01T13:38:25Z

content/docs/state-and-lifecycle.md


-We will move the `date` from props to state in three steps:
+हम तीन चरणों में date को props से state में भेजेंगे:


भेजेंगे -> badalenge

saranshkataria · 2019-04-01T13:38:53Z

content/docs/state-and-lifecycle.md

      </div>
    );
  }
 }
 ```

-2) Add a [class constructor](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Classes#Constructor) that assigns the initial `this.state`:
+2) एक [class constructor](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Classes#Constructor) जोड़ें जो प्रारंभिक `this.state` को असाइन करता है:


करता है -> karega

saranshkataria · 2019-04-01T13:39:25Z

content/docs/state-and-lifecycle.md

@@ -155,9 +156,9 @@ Note how we pass `props` to the base constructor:
  }
 ```

-Class components should always call the base constructor with `props`.
+क्लास के components को हमेशा बेस कंस्ट्रक्टर को `props` के साथ कॉल करना चाहिए।


translate components

revisit translation too, gramatically doesn't seem right

revisit translation too, gramatically doesn't seem right

Please suggest.

saranshkataria · 2019-04-01T13:40:30Z

content/docs/state-and-lifecycle.md


-3) Remove the `date` prop from the `<Clock />` element:
+3) `<Clock />` एलिमेंट से `date` prop निकालें:


date prop ko kuch aise nikale

Seems right the way it is. As "ko kuch aise nikale" is long and does not fit right.

saranshkataria · 2019-04-01T13:41:22Z

content/docs/state-and-lifecycle.md

@@ -195,17 +196,17 @@ ReactDOM.render(

 [**Try it on CodePen**](https://codepen.io/gaearon/pen/KgQpJd?editors=0010)


Missed translation here

Umm where??

saranshkataria · 2019-04-01T13:41:44Z

done till {#adding-lifecycle-methods-to-a-class}

saranshkataria · 2019-04-11T00:07:06Z

@charBap are you still working on this?

charBap · 2019-04-17T03:17:57Z

Please ignore the previous commit. I tried to make a different pull request.

saranshkataria · 2019-04-19T19:26:30Z

@charBap there is no such thing as ignoring a commit, you need to undo the changes

arshadkazmi42 · 2019-05-05T12:51:43Z

@charBap Any updates on this? Let us know if you need any help

saranshkataria · 2019-10-04T21:13:13Z

@charBap let us know if you are going to complete this, else we will be closing this PR out

saranshkataria · 2019-12-03T04:21:52Z

@arshadkazmi42 should we close this out, and wait for someone to pick it up from here, or do you want to do that?

arshadkazmi42 · 2019-12-03T04:36:45Z

@saranshkataria Let's close this, this already have some wrong commits. We do not want to spend time on fixing that.
I already have an open PR. Will pick this up once that is closed.

Edit:

Just checked, its almost done, let me pick this up. I will do the clean up and let's get this reviewed and merged.

arshadkazmi42 · 2020-02-27T17:12:52Z

@saranshkataria I am seeing alot of conflicts also in this. Lets close this. We can open new PR for this page?

saranshkataria · 2020-04-11T23:38:19Z

@arshadkazmi42 Sounds good. But let's keep a track of the PR in the main issue so as to someone can pick things up from where @charBap left them and that effort does not get wasted.

arshadkazmi42 · 2023-06-05T11:04:29Z

Closing due to inactivity

Translating page Style and Lifecycle.

e6377a5

Merge branch 'master' into charbap-hindi

998044e

tesseralis mentioned this pull request Mar 22, 2019

[OLD] Legacy Hindi Translation Progress #1

Closed

88 tasks

arshadkazmi42 requested changes Mar 22, 2019

View reviewed changes

Correcting errors.

9847f69

1. राज्य => State 2. प्रतिक्रिया => React 3. घटक => कौम्पोनॅन्ट

charBap added 2 commits March 21, 2019 23:28

Correcting errors

3bb784e

Correcting more errors

739d92b

correcting errors

08aa223

arshadkazmi42 requested changes Mar 22, 2019

View reviewed changes

correcting errors

e3a5204

Merge branch 'master' into charbap-hindi

c149161

Correcting errors

55861a4

correcting errors

5a0fe2c

arshadkazmi42 requested changes Mar 24, 2019

View reviewed changes

correcting errors

124d79e

correcting errors

6e0020c

saranshkataria reviewed Mar 28, 2019

View reviewed changes

content/docs/state-and-lifecycle.md Show resolved Hide resolved

charBap added 2 commits March 29, 2019 16:43

correcting errors

fd54fb8

correcting

b345014

saranshkataria reviewed Apr 1, 2019

View reviewed changes

saranshkataria added the awaiting author response label Apr 12, 2019

charBap added 2 commits April 13, 2019 23:57

correcting errors

70b3bbe

Translating API reference -> ReactDOM

c364000

arshadkazmi42 mentioned this pull request Apr 17, 2019

Translating API Reference -> ReactDOM #31

Closed

arshadkazmi42 self-assigned this Dec 8, 2019

arshadkazmi42 added the 2nd Review Second phrase of review label Jan 24, 2020

arshadkazmi42 removed their assignment Oct 20, 2022

arshadkazmi42 closed this Jun 5, 2023

arshadkazmi42 added the stale label Jun 5, 2023


		The `render` method will be called each time an update happens, but as long as we render `<Clock />` into the same DOM node, only a single instance of the `Clock` class will be used. This lets us use additional features such as local state and lifecycle methods.
		हर अपडेट पर `render` फंक्शन कॉल होगा, लेकिन जब तक हम `<Clock />` को एक ही DOM नोड में रेंडर करते हैं, तब तक `Clock` क्लास का केवल एक ही उदाहरण इस्तेमाल किया जाएगा। इससे हम लोकल state और Lifecycle विधियों जैसी अतिरिक्त सुविधाओं का उपयोग कर सकते हैं।


		We will move the `date` from props to state in three steps:
		हम तीन चरणों में date को props से state में भेजेंगे:


		3) Remove the `date` prop from the `<Clock />` element:
		3) `<Clock />` एलिमेंट से `date` prop निकालें:

		@@ -195,17 +196,17 @@ ReactDOM.render(

		[Try it on CodePen](https://codepen.io/gaearon/pen/KgQpJd?editors=0010)

Translating page Style and Lifecycle. #26

Translating page Style and Lifecycle. #26

Conversation

charBap commented Mar 21, 2019 • edited by arshadkazmi42 Loading

netlify bot commented Mar 21, 2019 • edited Loading

arshadkazmi42 left a comment

Choose a reason for hiding this comment

arshadkazmi42 commented Mar 22, 2019

arshadkazmi42 commented Mar 22, 2019

arshadkazmi42 commented Mar 22, 2019 • edited Loading

charBap commented Mar 22, 2019

charBap commented Mar 22, 2019

arshadkazmi42 commented Mar 22, 2019

arshadkazmi42 commented Mar 22, 2019 • edited Loading

arshadkazmi42 commented Mar 22, 2019

arshadkazmi42 left a comment

Choose a reason for hiding this comment

arshadkazmi42 commented Mar 23, 2019

charBap commented Mar 23, 2019

arshadkazmi42 commented Mar 23, 2019

arshadkazmi42 left a comment

Choose a reason for hiding this comment

arshadkazmi42 commented Mar 26, 2019

arshadkazmi42 commented Mar 26, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saranshkataria commented Mar 28, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saranshkataria commented Apr 1, 2019

saranshkataria commented Apr 11, 2019

charBap commented Apr 17, 2019

saranshkataria commented Apr 19, 2019

arshadkazmi42 commented May 5, 2019

saranshkataria commented Oct 4, 2019

saranshkataria commented Dec 3, 2019

arshadkazmi42 commented Dec 3, 2019 • edited Loading

Edit:

arshadkazmi42 commented Feb 27, 2020

saranshkataria commented Apr 11, 2020

arshadkazmi42 commented Jun 5, 2023

charBap commented Mar 21, 2019 •

edited by arshadkazmi42

Loading

netlify bot commented Mar 21, 2019 •

edited

Loading

arshadkazmi42 commented Mar 22, 2019 •

edited

Loading

arshadkazmi42 commented Mar 22, 2019 •

edited

Loading

arshadkazmi42 commented Dec 3, 2019 •

edited

Loading