Skip to content

ReactDOM Translation #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 14, 2019
Merged

ReactDOM Translation #11

merged 8 commits into from
Feb 14, 2019

Conversation

@anggras
Copy link
Contributor

@anggras anggras commented Feb 10, 2019

Yay! Hopefully it's good enough.

Please help to review, thanks!

@tesseralis tesseralis mentioned this pull request Feb 10, 2019
Closed
96 tasks
mazipan
mazipan requested changes Feb 11, 2019
View reviewed changes
@anggras
Copy link
Contributor Author

anggras commented Feb 11, 2019

Updated. Thank you for the comments 😆

regalius
regalius requested changes Feb 12, 2019
View reviewed changes
Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just need to adjust common terms and italicize some loanwords and we're good to go mas @anggras 👍

@anggras
Copy link
Contributor Author

anggras commented Feb 12, 2019

Done. Cheers!

mazipan
mazipan requested changes Feb 12, 2019
View reviewed changes
gedeagas
gedeagas approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@gedeagas gedeagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go, thank you for your contribution @anggras.

@mazipan @regalius Thank you for helping in the review process. You guys are awesome 🎉

@gedeagas gedeagas merged commit 14cfd24 into reactjs:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mazipan mazipan mazipan requested changes

@regalius regalius regalius approved these changes

@gedeagas gedeagas gedeagas approved these changes

@arfianadam arfianadam Awaiting requested review from arfianadam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anggras @regalius @mazipan @gedeagas