Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Forms #118

Merged
merged 18 commits into from
Nov 14, 2019
Merged

Translate Forms #118

merged 18 commits into from
Nov 14, 2019

Conversation

fajrizulfikar
Copy link
Contributor

Dear maintainers, i propose PR in translating Forms page.
Please review my work and give me some feedback.

@netlify
Copy link

netlify bot commented Oct 15, 2019

Deploy preview for id-reactjs ready!

Built with commit 1fd6f15

https://deploy-preview-118--id-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Oct 15, 2019

Deploy preview for idreactjs ready!

Built with commit 1fd6f15

https://deploy-preview-118--idreactjs.netlify.com

@fajrizulfikar fajrizulfikar changed the title Forms Translate Forms Oct 15, 2019
fajrizulfikar and others added 13 commits October 25, 2019 21:51
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@fajrizulfikar
Copy link
Contributor Author

@vferdiansyah i have updated several translations based on your suggestion, please review when you have a time

@fajrizulfikar
Copy link
Contributor Author

@vferdiansyah @resir014 i have updated my pr based on the suggestion, please re-review it when you have time.

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your help!

@resir014 resir014 merged commit 2d80cb8 into reactjs:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants