Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate How to Contribute #122

Merged
merged 8 commits into from
Oct 30, 2019

Conversation

paramithatm
Copy link
Contributor

@paramithatm paramithatm commented Oct 23, 2019

Translated How to Contribute page.
Please kindly review my work.
Thanks!

@netlify
Copy link

netlify bot commented Oct 23, 2019

Deploy preview for idreactjs ready!

Built with commit ba6e474

https://deploy-preview-122--idreactjs.netlify.com

@netlify
Copy link

netlify bot commented Oct 23, 2019

Deploy preview for id-reactjs ready!

Built with commit ba6e474

https://deploy-preview-122--id-reactjs.netlify.com

@paramithatm paramithatm changed the title Translate/how to contribute Translated how to contribute page Oct 24, 2019
@paramithatm paramithatm changed the title Translated how to contribute page Translate How to Contribute Oct 24, 2019
@paramithatm paramithatm marked this pull request as ready for review October 24, 2019 07:46
@paramithatm
Copy link
Contributor Author

@vferdiansyah I fixed the translation based on your review. Please kindly re-review it when you have time. Thank you!

Copy link
Contributor

@vferdiansyah vferdiansyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a couple hiccups, LGTM!

paramithatm and others added 2 commits October 25, 2019 16:27
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
@paramithatm
Copy link
Contributor Author

@vferdiansyah I fixed the translation based on your review. Please kindly re-review it when you have time. Thank you!

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@resir014 resir014 merged commit 3c52730 into reactjs:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants