Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Suspense for Data Fetching #182

Merged
merged 9 commits into from
Aug 14, 2020
Merged

Conversation

suliskh
Copy link
Contributor

@suliskh suliskh commented Jul 26, 2020

No description provided.

@netlify
Copy link

netlify bot commented Jul 26, 2020

Deploy preview for id-reactjs ready!

Built with commit e48d439

https://deploy-preview-182--id-reactjs.netlify.app

@netlify
Copy link

netlify bot commented Jul 27, 2020

Deploy preview for idreactjs ready!

Built with commit e48d439

https://deploy-preview-182--idreactjs.netlify.app

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good! Just one more thing:

Comment on lines 18 to 22
>Caution:
>
>This page describes **experimental features that are [not yet available](/docs/concurrent-mode-adoption.html) in a stable release**. Don't rely on experimental builds of React in production apps. These features may change significantly and without a warning before they become a part of React.
> Halaman ini menjelaskan **fitur eksperimental yang [belum tersedia](/docs/concurrent-mode-adoption.html) dalam versi rilis yang stabil**. Jangan mengandalkan _builds_ eksperimental dalam aplikasi React versi produksi. Fitur-fitur ini dapat berubah secara signifikan dan tanpa peringatan sebelum menjadi bagian dari React.
>
>This documentation is aimed at early adopters and people who are curious. **If you're new to React, don't worry about these features** -- you don't need to learn them right now. For example, if you're looking for a data fetching tutorial that works today, read [this article](https://www.robinwieruch.de/react-hooks-fetch-data/) instead.
> Dokumentasi ini ditujukan untuk pengguna awal dan orang-orang yang penasaran. **Jika Anda baru menggunakan React, jangan khawatirkan tentang fitur ini** -- Anda tidak perlu mempelajarinya sekarang
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this caution box is the similar across these sections, let's follow the translations already used in Concurrent Mode Introduction:

>Perhatian:
>
>Laman ini menjelaskan **fitur eksperimental yang [belum tersedia](/docs/concurrent-mode-adoption.html) dalam versi rilis yang stabil**. Jangan mengandalkan _build_ eksperimental dalam aplikasi React versi produksi. Fitur ini dapat berubah secara signifikan dan tanpa peringatan sebelum menjadi bagian dari React.
>
>Dokumentasi ini ditujukan untuk pengguna awal dan orang-orang yang penasaran. **Kalau anda baru menggunakan React, jangan khawatir tentang fitur ini** -- anda tidak perlu mempelajarinya sekarang.

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding suggested changes for experimental features banner.

content/docs/concurrent-mode-suspense.md Outdated Show resolved Hide resolved
content/docs/concurrent-mode-suspense.md Outdated Show resolved Hide resolved
content/docs/concurrent-mode-suspense.md Outdated Show resolved Hide resolved
@resir014 resir014 changed the title Add Suspense for Data Fetching Translation Translate Suspense for Data Fetching Aug 14, 2020
@resir014 resir014 merged commit d5915cb into reactjs:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants