Skip to content

New Indonesian translation: Tutorial: Tic-Tac-Toe #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 26, 2023
Merged

New Indonesian translation: Tutorial: Tic-Tac-Toe #335

merged 7 commits into from
Apr 26, 2023

Conversation

resir014
Copy link
Member

@resir014 resir014 commented Apr 26, 2023 •
edited by mhaidarhanif
Loading

Started work on translating the Tic-Tac-Toe tutorial to Indonesian.

Closes #373

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014 resir014 marked this pull request as ready for review April 26, 2023 06:25
@resir014 resir014 mentioned this pull request Apr 26, 2023
Open
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

r17x
r17x requested changes Apr 26, 2023
View reviewed changes
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mazipan
mazipan reviewed Apr 26, 2023
View reviewed changes
src/content/learn/tutorial-tic-tac-toe.md
@@ -2522,7 +2522,7 @@ export default function Game() {
}
```

If you click on any step in the game's history, the tic-tac-toe board should immediately update to show what the board looked like after that step occurred.
Jika Anda mengeklik langkah mana pun dalam riwayat permainan, papan *tic-tac-toe* akan segera diperbarui untuk menunjukkan seperti apa papan tersebut setelah langkah itu terjadi.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gua gak yakin sih ini, mengeklik atau mengklik yang bener.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mazipan Kalau sesuai KBBI, "mengeklik":
https://kbbi.kemdikbud.go.id/entri/mengeklik

@resir014 @mazipan
Apply suggestions from code review
6761cd9 
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014 resir014 requested review from mazipan and fzn0x April 26, 2023 10:49
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

fzn0x
fzn0x approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@fzn0x fzn0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@resir014 resir014 merged commit 12cc772 into main Apr 26, 2023
samnap11 pushed a commit to samnap11/id.react.dev that referenced this pull request Apr 26, 2023
@resir014 @mazipan @samnap11
New Indonesian translation: Tutorial: Tic-Tac-Toe (reactjs#335)
2eef8c7 
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
@resir014 resir014 mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazipan mazipan mazipan approved these changes

@r17x r17x r17x approved these changes

@fzn0x fzn0x fzn0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tutorial: Tic-Tac-Toe
4 participants
@resir014 @mazipan @r17x @fzn0x