Skip to content

docs translations: useCallback #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 1, 2023
Merged

docs translations: useCallback #365

merged 4 commits into from
May 1, 2023

Conversation

intanirnanda5796
Copy link
Contributor

@intanirnanda5796 intanirnanda5796 commented Apr 28, 2023 •
edited
Loading

translations for page: https://react.dev/reference/react/useCallback

Closes #398

@intanirnanda5796 intanirnanda5796 changed the title docs translations: useCallback (progress and draft) docs translations: useCallback Apr 29, 2023
@intanirnanda5796 intanirnanda5796 marked this pull request as ready for review April 29, 2023 12:16
r17x
r17x requested changes Apr 29, 2023
View reviewed changes
@r17x r17x requested a review from mhaidarhanif April 29, 2023 21:13
@mhaidarhanif
Copy link
Collaborator

mhaidarhanif commented Apr 30, 2023 •
edited
Loading

@intanirnanda5796 Please resolve all review comments from @r17x to reconfirm all the fixed changes (by clicking all the "Resolve conversation" buttons)

@github-actions
Copy link

github-actions bot commented Apr 30, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@intanirnanda5796
Copy link
Contributor Author

@intanirnanda5796 Please resolve all review comments from @r17x to reconfirm.

image

i have been resolved all review comments from @r17x . but in the screenshot i have been attach, i want ask is it need to change or not?

@mhaidarhanif
Copy link
Collaborator

mhaidarhanif commented Apr 30, 2023 •
edited
Loading

@intanirnanda5796 I meant clicking the "Resolve conversation" buttons to reconfirm. Therefore leaving only 1 conversation that still needs to be discussed or fixed. Or let's just wait for @r17x to resolve and confirm that remaining conversation.

image

@intanirnanda5796
Copy link
Contributor Author

intanirnanda5796 commented Apr 30, 2023 •
edited
Loading

@intanirnanda5796 I meant clicking the "Resolve conversation" buttons to reconfirm. Therefore leaving only 1 conversation that still needs to be discussed or fixed. Or let's just wait for @r17x to resolve and confirm that remaining conversation.

image

ah oke. sorry for miss understanding.
done.

@mhaidarhanif
Copy link
Collaborator

mhaidarhanif commented Apr 30, 2023 •
edited
Loading

@intanirnanda5796 Alright then it will leave the last unresolved conversation: #365 (comment) that needs to be confirmed again by @r17x

@intanirnanda5796
Copy link
Contributor Author

i have been push remove italic when it translate to Bahasa. if there any miss in my translate, feel free to comment mas @mhaidarhanif @r17x

@r17x r17x force-pushed the docs/translations/useCallback branch from b08de45 to d9c915f Compare May 1, 2023 10:27
@r17x r17x merged commit facd556 into reactjs:main May 1, 2023
r17x pushed a commit that referenced this pull request May 8, 2023
@intanirnanda5796 @r17x
docs translations: useCallback (#365)
4b7e805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r17x r17x r17x approved these changes

@mhaidarhanif mhaidarhanif Awaiting requested review from mhaidarhanif

@resir014 resir014 Awaiting requested review from resir014

@zainfathoni zainfathoni Awaiting requested review from zainfathoni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useCallback
3 participants
@intanirnanda5796 @mhaidarhanif @r17x