-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate Getting Started #60
Conversation
Deploy preview for idreactjs ready! Built with commit f1dc2b8 |
Deploy preview for id-reactjs ready! Built with commit f1dc2b8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave some reviews. There are also some unfinished translations though.
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
…g into tr_i_getting_started
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
thank's for review and give me many advices, can you check again @wisn thank you so much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We need more reviews from others.
@vferdiansyah I've fixed it, can you check again the update thanks. |
LGTM! Thanks for updating @hryer! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the help @hryer! Ada beberapa poin kecil yang perlu diubah, setelah itu dapat saya merge.
Co-Authored-By: Resi Respati <resir014@gmail.com>
Co-Authored-By: Resi Respati <resir014@gmail.com>
sudah gan thank's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are several recommendations, mostly are typos and quick fixes, while others should be discussed further.
Co-Authored-By: Griko Nibras <grikomsn@gmail.com>
Co-Authored-By: Griko Nibras <grikomsn@gmail.com>
Co-Authored-By: Griko Nibras <grikomsn@gmail.com>
Co-Authored-By: Griko Nibras <grikomsn@gmail.com>
@hryer can you resolve the conflicts? |
done ya gan |
Thanks for your help @hryer! This is all good to merge now. |
mohon reviewnya mas mas, maaf lama hehe :)