Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Getting Started #60

Merged
merged 47 commits into from
Nov 8, 2019
Merged

Conversation

hryer
Copy link
Contributor

@hryer hryer commented Mar 17, 2019

mohon reviewnya mas mas, maaf lama hehe :)

@netlify
Copy link

netlify bot commented Mar 17, 2019

Deploy preview for idreactjs ready!

Built with commit f1dc2b8

https://deploy-preview-60--idreactjs.netlify.com

@netlify
Copy link

netlify bot commented Mar 17, 2019

Deploy preview for id-reactjs ready!

Built with commit f1dc2b8

https://deploy-preview-60--id-reactjs.netlify.com

Copy link

@wisn wisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave some reviews. There are also some unfinished translations though.

content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
wisn and others added 23 commits April 13, 2019 20:09
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
Co-Authored-By: hryer <harry.ermawan@ralali.com>
@hryer
Copy link
Contributor Author

hryer commented May 8, 2019

thank's for review and give me many advices, can you check again @wisn thank you so much.

Copy link

@wisn wisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need more reviews from others.

content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
@hryer
Copy link
Contributor Author

hryer commented Jun 9, 2019

@vferdiansyah I've fixed it, can you check again the update thanks.

@vferdiansyah
Copy link
Contributor

LGTM! Thanks for updating @hryer!

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help @hryer! Ada beberapa poin kecil yang perlu diubah, setelah itu dapat saya merge.

content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
hryer and others added 2 commits July 21, 2019 20:43
Co-Authored-By: Resi Respati <resir014@gmail.com>
Co-Authored-By: Resi Respati <resir014@gmail.com>
@hryer
Copy link
Contributor Author

hryer commented Jul 21, 2019

Thanks for the help @hryer! Ada beberapa poin kecil yang perlu diubah, setelah itu dapat saya merge.

sudah gan thank's

Copy link
Member

@grikomsn grikomsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are several recommendations, mostly are typos and quick fixes, while others should be discussed further.

content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
content/docs/getting-started.md Outdated Show resolved Hide resolved
@grikomsn grikomsn changed the title Translated Getting Started Translate Getting Started Jul 22, 2019
hryer and others added 4 commits July 24, 2019 13:05
Co-Authored-By: Griko Nibras <grikomsn@gmail.com>
Co-Authored-By: Griko Nibras <grikomsn@gmail.com>
Co-Authored-By: Griko Nibras <grikomsn@gmail.com>
Co-Authored-By: Griko Nibras <grikomsn@gmail.com>
@vferdiansyah
Copy link
Contributor

@hryer can you resolve the conflicts?

@hryer
Copy link
Contributor Author

hryer commented Oct 27, 2019

@hryer can you resolve the conflicts?

done ya gan

@resir014
Copy link
Member

resir014 commented Nov 8, 2019

Thanks for your help @hryer! This is all good to merge now.

@resir014 resir014 merged commit c319395 into reactjs:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants