-
Notifications
You must be signed in to change notification settings - Fork 84
Translate: Adding Interactivity #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate: Adding Interactivity #434
Conversation
…arn and sidebarHome
68840cb
to
e39a4dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ciao @oxcened, grazie mille!! 🚀
Secondo me è ottima 😄
Ho lasciato qualche piccolo commento ma nulla di che.
Facci sapere cosa ne pensi! :)
Grazie a te è un piacere!! Ho visto che quasi tutti i commenti riguardano il case dei titoli delle sezioni. Ero consapevole che non coincidessero con l’originale, ma prima di iniziare ho visto #427 e i titoli erano stati scritti tutti in pascal case perciò mi sono allineato. Su questo quindi vi chiedo di prendere una decisione perché altrimenti c’è un disallineamento. Ho visto che tutte le altre pagine hanno il normal case, solo quella fa eccezione, immagino sia stato fatto per matchare il case dei titoli sulla sidebar. Io personalmente penso sia meglio che il case di qualsiasi testo coincida sempre con quello originale :) |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
4acbcf6
to
a514afe
Compare
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Ciao :) |
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Ottimo mi trovi d'accordo su tutto! Ho apportato le modifiche richieste 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grazie @oxcened ! 🚀
Partially addresses #418.
sidebarLearn
.sidebarHome
.