Skip to content

Translate design-principles #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 2, 2019
Merged

Translate design-principles #133

merged 8 commits into from
Mar 2, 2019

Conversation

hand-dot
Copy link
Contributor

This PR is part of Issue #4.
Translation: Design Principles

レビューをお願いいたします。

@netlify
Copy link

netlify bot commented Feb 20, 2019 •
edited
Loading

Deploy preview for ja-reactjs ready!

Built with commit eeb050f

https://deploy-preview-133--ja-reactjs.netlify.com

@potato4d potato4d requested review from potato4d and removed request for potato4d February 20, 2019 04:51
@potato4d
Copy link
Member

今晩見れそうなら assign 入れてみます 🙇

@hand-dot
Copy link
Contributor Author

今晩見れそうなら assign 入れてみます 🙇

ありがとうございます！よろしくお願い致します。

@smikitky smikitky added the 🚫 in intial review 初期レビューの真っ最中 label Feb 25, 2019
smikitky
smikitky requested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@smikitky smikitky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅くなりましたがレビューしました。数が多いですが、特にドキュメントの後半で直訳すぎる部分が散見されましたので、読みやすいように変えたところが多くなっています。よろしくお願いします。

"Files Changed" のタブ側に移動すれば複数のサジェスチョンを1コミットで適用できますので使ってみてください。

@smikitky smikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 25, 2019
@tesseralis tesseralis mentioned this pull request Feb 25, 2019
Closed
90 tasks
@smikitky @hand-dot
Apply suggestions from code review
c1e18c4 
Co-Authored-By: hand-dot <kyouhei.fukuda0729@gmail.com>
@hand-dot
Copy link
Contributor Author

@smikitky
レビューしていただきありがとうございます。
指摘を確認し、サジェスチョンを適用しました。
よろしくお願い致します。

@smikitky
Copy link
Member

ありがとうございました。他の方のレビューをお待ちください

koba04
koba04 requested changes Mar 1, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hand-dot
翻訳お疲れ様です！
一点だけ用語の確認お願いします 🙏

@koba04 @hand-dot
Update content/docs/design-principles.md
9d70d4a 
Co-Authored-By: hand-dot <kyouhei.fukuda0729@gmail.com>
@hand-dot
Copy link
Contributor Author

hand-dot commented Mar 2, 2019

@koba04
ありがとうございます！
指摘内容を取り込みました。

よろしくお願いします。

koba04
koba04 approved these changes Mar 2, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hand-dot ありがとうございます！ 👍

@koba04 koba04 merged commit 8327dae into reactjs:master Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba04 koba04 koba04 approved these changes

@smikitky smikitky smikitky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hand-dot @potato4d @smikitky @koba04