Skip to content

translate lifting-state-up doc #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 3, 2019
Merged

translate lifting-state-up doc #15

merged 4 commits into from
Feb 3, 2019

Conversation

sasurau4
Copy link
Contributor

@sasurau4 sasurau4 commented Feb 1, 2019

This PR is part of #4
Please review and comment 🙏

@smikitky smikitky self-requested a review February 1, 2019 16:08
@smikitky
Copy link
Member

smikitky commented Feb 1, 2019

ぱっと見はとてもいい感じだと思います。細かいレビューはちょっとお待ちください。

smikitky
smikitky requested changes Feb 2, 2019
View reviewed changes
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大量ですみません。大多数はスペースとかの些細なスタイルの問題です。ご確認をお願いします。

@sasurau4
Copy link
Contributor Author

sasurau4 commented Feb 2, 2019

@smikitky
むっちゃスタイルガイドに沿ってなかったので一掃しました
レビューお願いします 🙏

@tesseralis tesseralis mentioned this pull request Feb 2, 2019
Closed
90 tasks
smikitky
smikitky requested changes Feb 3, 2019
View reviewed changes
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらの2つだけ改めて対応をお願い致します。

@smikitky @sasurau4
Apply suggestions from code review
4950619 
fix pointed out

Co-Authored-By: sasurau4 <sasurau4@gmail.com>
@sasurau4
Copy link
Contributor Author

sasurau4 commented Feb 3, 2019

@smikitky 対応しました 👍

@smikitky smikitky merged commit ab1da7c into reactjs:master Feb 3, 2019
@smikitky
Copy link
Member

smikitky commented Feb 3, 2019

ありがとうございました！

@sasurau4 sasurau4 deleted the translate/lifting-state-up branch February 15, 2019 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smikitky smikitky smikitky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sasurau4 @smikitky