-
Notifications
You must be signed in to change notification settings - Fork 183
Translate react-without-es6 #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assign @smikitky as a reviewer
とのことでしたが、変更できないので no reviews のままです。すみません、レビューお願いします!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
レビューしましたのでこちらの確認をよろしくお願いします!
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
納得のいく suggestions だったので一通り取り込みました。 |
私の方ではOKです。@koba04 さん待ち。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ginpei 不要なーがあったのでその点だけコメントしました!
Co-Authored-By: ginpei <ginpei@gmail.com>
Co-Authored-By: ginpei <ginpei@gmail.com>
そのルールを失念しておりました。自分でも見直して修正しました。 🙏 |
「レガシー」は一般的なカタカナ日本語と判断して残しました。 |
ありがとうございました! |
Advanced Guides > React Without ES6の翻訳です。