Skip to content

Translate jsx-in-depth #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2019
Merged

Conversation

sato11
Copy link
Contributor

@sato11 sato11 commented Feb 4, 2019

This PR is part of #4.
Added translation to JSX In Depth section.

Quite a few sentences are originally taken from crowdin. I have filled missing parts and arranged or rewritten some of them to make it stylistically more consistent.

よろしくお願いします :) @smikitky

@tesseralis tesseralis mentioned this pull request Feb 5, 2019
90 tasks
@smikitky smikitky self-requested a review February 5, 2019 05:53
@smikitky smikitky added the 🚫 in intial review 初期レビューの真っ最中 label Feb 7, 2019
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほとんど大丈夫ですが少しだけ提案です。

@smikitky smikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 7, 2019
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sato11
翻訳ありがとうございます 🙏

smikitky さんの指摘の変更点以外は特になさそうです。
一点、タイトルの部分で対案があったので書いておきました〜。

@sato11
Copy link
Contributor Author

sato11 commented Feb 7, 2019

@smikitky @potato4d
レビューありがとうございました。
ご指摘に沿う形で変更を行いましたので、引き続きよろしくお願いします。

@sato11 sato11 force-pushed the translate/jsx-in-depth branch from 7495cec to 14b6604 Compare February 13, 2019 12:17
@sato11
Copy link
Contributor Author

sato11 commented Feb 13, 2019

@smikitky @potato4d
こちらのコメント見逃してしまっておりすみませんでした。
適用しましたので再度ご確認いただけますでしょうか、よろしくお願いします 🙏
#4 (comment)

@smikitky
Copy link
Member

ありがとうございます!

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです!

@potato4d potato4d merged commit 2cb8402 into reactjs:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants