-
Notifications
You must be signed in to change notification settings - Fork 183
Translate hooks-rules #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[imo]
clearly visible
なので、ソースコードから可視化されていることが言いたいのかなと思ったのですがいかがでしょう?参照だとアクセス可能であることと取られる可能性があるかなと思いました。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
「ロジックが明確になります」はちょっと意味が変わってしまうように思います。「ロジックが不明確」とは主に、変数名の付け方が下手などの理由で読みづらいけど正しく動くコードに対して使われる表現のような感じがします。
stateful logic が「コンポーネントのソースコードから可視化されている」と「コンポーネントのソースコードから参照できる」であれば、個人的にはどちらでもいいのですが、そもそもあまり意味の違いがあるような気がしません。ループ内やコンポーネント外で useState を使っても、その返り値の state/setState はコンポーネントの他の部分から正しく利用できませんよ、ということを "not visible" と表現しているのだと思うので、まさに「アクセス可能」のことだと思いますし、「可視化」でも「参照可能」でも同じのような気がしているのですが、如何でしょうか。