Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate FAQ > File Structure #107

Merged
merged 9 commits into from
Jul 28, 2019
Merged

Translate FAQ > File Structure #107

merged 9 commits into from
Jul 28, 2019

Conversation

highspirit7
Copy link
Contributor

@highspirit7 highspirit7 commented Apr 29, 2019 •
edited
Loading

@netlify
Copy link

netlify bot commented Apr 29, 2019 •
edited
Loading

Deploy preview for ko-reactjs-org ready!

Built with commit f6a0fb5

https://deploy-preview-107--ko-reactjs-org.netlify.com

@highspirit7
Copy link
Contributor Author

Have 2 issues.

  1. According to The National Institute of the Korean Language, '디렉터리' is correct. However, it seems that many people use '디렉토리'. Anyway, I chose '디렉토리'. but not sure yet which one is better...

  2. I did not really translate the word 'colocation'. I thought it would be a bit awkward if it is literally translated. So, I chose '코로케이션' instead which is based on how the word is pronounced in Korean.

taehwanno
taehwanno reviewed May 23, 2019
View reviewed changes
content/docs/faq-structure.md Outdated

As projects grow larger, they often use a mix of both of the above approaches in practice. So choosing the "right" one in the beginning isn't very important.
완전히 난관에 봉착해있다면, 모든 파일을 하나의 폴더에 보관하는 방법으로 우선 시작해보세요. 결국에는 프로젝트가 충분히 커져서 일부 파일을 나머지로부터 분리해 보관하기 원하게 될 것입니다. 그 시점까지 어떤 파일들을 가장 자주 묶어서 수정하는지 충분히 알 수 있게 될 것입니다. 일반적으로, 자주 함께 변경되는 파일들을 같이 보관하는 것이 좋은 방법입니다. 이러한 원칙을 "코로케이션"이라고 부릅니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코로케이션은 영문과 병기해서 "코로케이션(colocation)"으로 수정하는게 좋아보여요.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 말씀해주신대로 수정했습니다.

@highspirit7
Copy link
Contributor Author

I already applied the review by @taehwanno. butI found one thing I did not correct.

So I just corrected and committed. I think this pull request need to be labelled as "needs review".

@taehwanno
Copy link
Member

Thanks. I changed the label to "needs review"

taehwanno
taehwanno approved these changes Jul 27, 2019
View reviewed changes
Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

hg-pyun
hg-pyun approved these changes Jul 28, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taehwanno taehwanno merged commit 487232e into reactjs:master Jul 28, 2019
@tesseralis tesseralis mentioned this pull request Jul 28, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taehwanno taehwanno taehwanno approved these changes

@hg-pyun hg-pyun hg-pyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@highspirit7 @taehwanno @hg-pyun