Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate code-splitting.md #55
Translate code-splitting.md #55
Changes from all commits
3e5d87d
b0a5eac
4738df2
c1cbc9c
91a24f8
491882e
d841c75
e82f6da
ccc830d
00bae2c
2c267de
ac82f81
186c815
602e491
12dbe01
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
route는 번역하지 않고
라우트
로 사용 하는게 어떨까요?경로
라고 번역되니 의미가 잘 전달되지 않는 것 같아서요.@taehwanno
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simsim0709 express.js 번역도 라우팅으로 되어 있는 걸 보니 무리는 없을 것 같네요. 고민하다가
경로
리뷰 드렸는데라우트
로 변경에 동의합니다 :)@liante0904 변경 부탁드릴게요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taehwanno @simsim0709
경로(routes)
에서라우트
로 변경하면 될까요?하단
Route-based code splitting
항목에서how to setup route-based code splitting
를경로 기반
으로 번역하였는데 이 경우도라우트 기반
으로 변경하면 될지 확인하고 수정 commit 하려고 합니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liante0904 네 맞습니다 :) 🚀