Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate refs-must-have-owner #69

Merged

Conversation

simsim0709
Copy link
Collaborator

Progress

Sorry, something went wrong.

@netlify
Copy link

netlify bot commented Mar 10, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit 385c7cb

https://deploy-preview-69--ko-reactjs-org.netlify.com

Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hg-pyun added 2 commits April 23, 2019 16:50

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
>
> addComponentAsRefTo(...): Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component's `render` method, or you have multiple copies of React loaded.
>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19 20행은 삭제되어야 할 것 같아요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

실제 경고 문구는 그대로 유지 하라고 해서 남겨 두었어요~

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@simsim0709 simsim0709 merged commit 7147f9b into reactjs:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants