Translate render-props #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ko-reactjs-org ready! Built with commit bfbd215 |
|
Deploy preview for ko-reactjs-org ready! Built with commit c09fed5 |
|
Deploy preview for ko-reactjs-org ready! Built with commit 2d4309d |
cadenzah
reviewed
Mar 30, 2019
cadenzah
reviewed
Mar 30, 2019
cadenzah
reviewed
Mar 30, 2019
cadenzah
reviewed
Mar 31, 2019
cadenzah
reviewed
Mar 31, 2019
simsim0709
reviewed
Apr 8, 2019
simsim0709
reviewed
Apr 8, 2019
simsim0709
reviewed
Apr 8, 2019
content/docs/render-props.md
Outdated
| 예를 들어, 마우스 주위에 고양이 그림을 보여주는 `<Cat>` 컴포넌트를 생각해 보겠습니다. 우리는 `<Cat mouse={{x, y}}>` prop을 통해 Cat 컴포넌트에 마우스 좌표를 전달해주고 화면에 어떤 위치에 이미지를 보여줄지 알려 주고자 합니다. | ||
|
|
||
| As a first pass, you might try rendering the `<Cat>` *inside `<Mouse>`'s `render` method*, like this: | ||
| 첫 번째 방법으로는, 다음과 같이 `<Mouse>` 컴포넌트의 *render 메서드안에* `<Cat>` 컴포넌트를 넣어 렌더링하는 방법이 있습니다: |
Collaborator
There was a problem hiding this comment.
"있습니다:" -> "있습니다." 콜론 제거되야 할 것 같습니다.
Member
Author
There was a problem hiding this comment.
이부분은 원문을 살려 :를 표현했는데 어느게 좋을까요?
다른 부분에서도 동일하게 컨벤션을 맞추고 있습니다.
Collaborator
There was a problem hiding this comment.
다른 메인테이너 분들 의견 들어 보는게 좋을 것 같습니다! @taehwanno @taggon @gnujoow
Member
There was a problem hiding this comment.
:는 제거하는것이 best practice로 제안되어있습니다. 제거하는것이 컨벤션을 유지하는데 좋을것 같아요
Member
There was a problem hiding this comment.
simsim0709
reviewed
Apr 8, 2019
simsim0709
reviewed
Apr 8, 2019
simsim0709
reviewed
Apr 8, 2019
simsim0709
reviewed
Apr 8, 2019
Member
|
#73 (review) |
Member
Author
|
@gnujoow @simsim0709 @cadenzah 확인 부탁드려요:) |
Member
Author
|
머지 부탁드려요 ㅎㅎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress