Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate: renderToReadableStream #774

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Translate: renderToReadableStream #774

merged 6 commits into from
Oct 3, 2023

Conversation

Jay-WKJun
Copy link
Contributor

@Jay-WKJun Jay-WKJun commented Sep 17, 2023 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Sep 17, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@hg-pyun
Copy link
Member

hg-pyun commented Sep 18, 2023

늦어서 죄송합니다. 내일 리뷰해보겠습니다 🙏

hg-pyun
hg-pyun requested changes Sep 23, 2023
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR본문에 있는 체크리스트를 한번 확인한 후에 다시 리뷰요청 부탁드려요!

src/content/reference/react-dom/server/renderToReadableStream.md Outdated
* **optional** `nonce`: [`script-src` Content-Security-Policy](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/script-src)를 허용하기 위한 [`nonce`](http://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#nonce) (한번만 사용되는) 문자열입니다.
* **optional** `onError`: [회복할 수 있든](#recovering-from-errors-outside-the-shell) 있든 [없든] 상관없이, 서버에서 에러가 발생할 때마다 호출되는 콜백입니다. 기본적으로, 이 콜백은 `console.error`만 호출합니다. [크래시 리포트를 로그하기](#logging-crashes-on-the-server) 위해 오버라이드하거나, [상태 코드를 조정하기](#setting-the-status-code) 위해 오버라이드할 수 있습니다.
* **optional** `progressiveChunkSize`: 청크의 바이트 수를 설정합니다. [기본 휴리스틱에 대해 더 읽어보기.](https://github.com/facebook/react/blob/14c2be8dac2d5482fda8a0906a31d239df8551fc/packages/react-server/src/ReactFizzServer.js#L210-L225)
* **optional** `signal`: [서버 렌더링을 취소](#aborting-server-rendering)하고, 그 나머지를 클라이언트에 렌더하기 위한 [거절 신호(abort signal)](https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal)를 설정합니다.

#### Returns {/*returns*/}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반환값으로 번역해주세요.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정되었습니다.

b682fc3

src/content/reference/react-dom/server/renderToReadableStream.md Outdated
@@ -115,17 +114,17 @@ export default function App() {
}
```

React will inject the [doctype](https://developer.mozilla.org/en-US/docs/Glossary/Doctype) and your <CodeStep step={2}>bootstrap `<script>` tags</CodeStep> into the resulting HTML stream:
리액트는 [doctype](https://developer.mozilla.org/en-US/docs/Glossary/Doctype)와 <CodeStep step={2}>bootstrap `<script>` 태그들</CodeStep>을 결과 HTML 스트림에 주입합니다:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리액트는 번여하면 안되는 용어에 포함되어 있습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정되었습니다.

b682fc3

src/content/reference/react-dom/server/renderToReadableStream.md Outdated
@@ -158,10 +157,10 @@ export default function App({ assetMap }) {
}
```

On the server, render `<App assetMap={assetMap} />` and pass your `assetMap` with the asset URLs:
서버에선 `<App assetMap={assetMap} />`을 렌더하고, 에셋 URL들과 함께 `assetMap`을 전달합니다:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"render는 랜더링하다"로 번역해주세요.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정되었습니다.

622240e

@hg-pyun hg-pyun mentioned this pull request Sep 23, 2023
Closed
@hg-pyun
Copy link
Member

hg-pyun commented Oct 3, 2023

고생하셨습니다 👍

@hg-pyun hg-pyun merged commit a59537f into reactjs:main Oct 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hg-pyun hg-pyun hg-pyun approved these changes

@taehwanno taehwanno Awaiting requested review from taehwanno taehwanno is a code owner

@simsim0709 simsim0709 Awaiting requested review from simsim0709 simsim0709 is a code owner

@gnujoow gnujoow Awaiting requested review from gnujoow gnujoow is a code owner

@b9words b9words Awaiting requested review from b9words b9words is a code owner

@taggon taggon Awaiting requested review from taggon taggon is a code owner

@MaxKim-J MaxKim-J Awaiting requested review from MaxKim-J MaxKim-J is a code owner

@eomttt eomttt Awaiting requested review from eomttt eomttt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jay-WKJun @hg-pyun