Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Home Page #8

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Translate Home Page #8

merged 2 commits into from
Feb 13, 2019

Conversation

chatoo2412
Copy link
Contributor

@chatoo2412 chatoo2412 mentioned this pull request Feb 9, 2019
Open
gnujoow
gnujoow reviewed Feb 9, 2019
View reviewed changes
Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a my translation suggestion for the first sentence and punctuation mistake as a comment.

others are looks good to me ;)

taehwanno
taehwanno reviewed Feb 9, 2019
View reviewed changes
Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍

ENvironmentSet
ENvironmentSet reviewed Feb 9, 2019
View reviewed changes
Copy link
Contributor

@ENvironmentSet ENvironmentSet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked your translation, and it looks great to me. but I feel something lacking(just a little), could you check my suggestion and comment about it?

@chatoo2412 chatoo2412 force-pushed the translate/home branch 3 times, most recently from 835d06c to 4226b74 Compare February 10, 2019 06:18
taggon
taggon reviewed Feb 10, 2019
View reviewed changes
@taehwanno
Copy link
Member

@chatoo2412 Could you please resolve conflict?

@hg-pyun hg-pyun self-assigned this Feb 11, 2019
@hg-pyun
Copy link
Member

hg-pyun commented Feb 11, 2019

@ALL
If review is done, please approved.

@hg-pyun hg-pyun removed their assignment Feb 11, 2019
@tesseralis
Copy link
Member

@taehwanno are we ready to merge this in?

@taehwanno
Copy link
Member

@tesseralis Yes, I think so. but I'm waiting for the approval of other reviewers who participated.

@tesseralis
Copy link
Member

@taehwanno I think it's a good idea to come up with a system for reviews. After all, you can't expect everyone listed as a reviewer to look over it!

Do you want only one person to approve before merging or two? This has two approvals, so are you and @hg-pyun ready to merge this in?

@hg-pyun
Copy link
Member

hg-pyun commented Feb 13, 2019 •
edited
Loading

@tesseralis

  1. Review comment is all reset.
  2. If more than two main member are approved

I think it's good to merge.

@hg-pyun hg-pyun merged commit c42b253 into reactjs:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taggon taggon taggon left review comments

@gnujoow gnujoow gnujoow left review comments

@SeonHyungJo SeonHyungJo SeonHyungJo left review comments

@ENvironmentSet ENvironmentSet ENvironmentSet left review comments

@taehwanno taehwanno taehwanno approved these changes

@hg-pyun hg-pyun hg-pyun approved these changes

@simsim0709 simsim0709 Awaiting requested review from simsim0709

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@chatoo2412 @taehwanno @hg-pyun @tesseralis @taggon @gnujoow @SeonHyungJo @ENvironmentSet