New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate List and Keys #85

Merged

simsim0709 merged 7 commits into reactjs:master from Jravvit:lists-and-keys

Apr 24, 2019

Contributor

Jravvit commented Mar 31, 2019 •

edited by hg-pyun

Loading

Progress

번역 초안 작성 (Draft translation)
공통 스타일 가이드 확인 (Check the common style guide)
모범사례 확인 (Check best practices)
용어 확인 (Check the term)
맞춤법 검사 (Spelling check)
리뷰 반영 (Resolve reviews)

Jravvit added 3 commits

March 31, 2019 20:04


          Add list and keys

887fb7f


          Add list and keys

fde4493


          Fix typo

c5e7214

netlify bot commented Mar 31, 2019 •

edited

Loading

Deploy preview for ko-reactjs-org ready!

Built with commit 1f8d60b

https://deploy-preview-85--ko-reactjs-org.netlify.com

taehwanno added the needs review label

Member

taehwanno commented Apr 1, 2019

Progress의 각 단계 확인하시고 체크 부탁드려요 :)

tesseralis mentioned this pull request

Korean Translation Progress #1

Open


          Fix best practices

bcae4d5

simsim0709 reviewed

View reviewed changes

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved

simsim0709 reviewed

View reviewed changes

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved

simsim0709 added needs author response and removed needs review labels

hg-pyun requested changes

View reviewed changes

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved

content/docs/lists-and-keys.md Outdated Show resolved Hide resolved

hg-pyun and others added 3 commits

April 4, 2019 11:43


          Merge branch 'master' into lists-and-keys

4f82d07


          Merge remote-tracking branch 'upstream/master' into lists-and-keys

fd64103


          Fix typo

1f8d60b

Contributor Author

Jravvit commented Apr 22, 2019

@hg-pyun @simsim0709 늦어서 죄송합니다! 리뷰 반영 했습니다.

hg-pyun added needs +1 approval and removed needs author response labels

hg-pyun approved these changes

View reviewed changes

Member

hg-pyun left a comment

고생하셨습니다.

simsim0709 self-requested a review

April 24, 2019 08:23

simsim0709 approved these changes

View reviewed changes

Collaborator

simsim0709 left a comment

수고하셨습니다~ 👍

simsim0709 merged commit fa260ca into reactjs:master

taehwanno removed the needs +1 approval label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet