This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Fixed event handler update bug in (non-fiber/legacy) ReactART #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug caused updated handlers to be ignored once set. The fix is simple and I've added unit test coverage as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line in
ReactARTcauses a bug that will ignore updated event handlers for a given event type once set (eg if you setonClick={handler1}and then later setonClick={handler2}, the first handler will continue to receive events).This PR fixes that issue by using the intended
handleEventproxy method.. I've added unit test coverage as well.Note that this PR partially overlaps with PR #105 since I had to patch the imports (eg
react/libtoreact-dom/lib) and multi-child mixin (egReactMultiChildtoReactMultiChild.Mixin).