This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Potential bug fix with prop updates not rerendering with new data #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the old values instead of the new values.
jhudson8
added a commit
that referenced
this pull request
Jan 12, 2015
Potential bug fix with prop updates not rerendering with new data
austinpray
pushed a commit
that referenced
this pull request
May 18, 2016
Fixes chart creation on initializeChart
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a nifty module! Thanks for sharing.
I was trying to re-render my line chart by changing values in the parent component, so that the LineChart would recognize a prop update, but I discovered that it wouldn't re-render the chart using the new values. If I tried updating its props a second time, it would use the values from the first update.
I think initializeChart should use the props/nextProps argument instead of this.props because this.props gets gets updated after componentWillReceiveProps finishes. Let me know what you think.