Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for function components that return null #924

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rvetere
Copy link
Contributor

@rvetere rvetere commented May 27, 2024

Add support for function components that only return null:

export const DataTableColumnDocs: FunctionComponent<
  IDataTableColumn<object>
> = () => {
  return null;
};

and add support for components that only return a prop (directly, without a fragment):

export const AuthenticatedBoundary = ({
  children,
  fallback,
}: AuthenticatedBoundaryProps) => {
  const { isLoggedIn } = useAuthentication();

  if (!isLoggedIn) {
    return fallback;
  }

  return children;
};

Fixes #926

Copy link

changeset-bot bot commented May 27, 2024

⚠️ No Changeset found

Latest commit: 656b2f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented May 27, 2024

Deploy Preview for react-docgen ready!

Name Link
🔨 Latest commit 656b2f3
🔍 Latest deploy log https://app.netlify.com/sites/react-docgen/deploys/66557967c7dbfb0008ac0d97
😎 Deploy Preview https://deploy-preview-924--react-docgen.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

const def = parse.statement(`
function Foo (props) {
return null;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What worries me is that literaly any function that returns null will be detected as react component.
Same for the other usecase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No support for components that directly return null
2 participants