issue #8 : case insensitive css attributes, import react's attribute map... #20
Conversation
…ribute mapping into attribute map
src/htmltojsx.js
Outdated
There was a problem hiding this comment.
Please put a single space after the // and capitalise the first word
|
Sorry it took me so long to see this, I don't think I got an email about it :( |
|
@Daniel15 |
|
I think this change should be fine, but it looks like there's currently some merge conflicts. I'd be happy to merge it if you resolve the conflicts :) |
Conflicts: package.json
|
@Daniel15 bump |
src/htmltojsx.js
Outdated
There was a problem hiding this comment.
Use triple equals for string equality, !==.
Can you add a test for the browser prefix case?
There was a problem hiding this comment.
Might be cleaner to use charAt since you know it's a String.
|
@ssorallen |
src/htmltojsx.js
Outdated
There was a problem hiding this comment.
startsWith is not yet standard and not widely supported.
test/htmltojsx-test.js
Outdated
There was a problem hiding this comment.
Fix the spacing here please - Looks like the it lines use tabs but everything else uses spaces
There was a problem hiding this comment.
Alright, hopefully that fixes the last of it. Do you have some linting rules that could be put in here?
There was a problem hiding this comment.
Thanks! I'll have to see if I can figure out which linting tools to use, as I don't have experience with setting up linters.
issue #8 : case insensitive css attributes, import react's attribute map...
5 participants
...ping into attribute map
issue #8