You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Really, the issue is that the parentSelector will not cause a DOM update if the modal is not open when the parentSelector is changed. In componentWillReceiveProps,
if (!this.props.isOpen && !isOpen) return;
var currentParent = getParentElement(this.props.parentSelector);
var newParent = getParentElement(newProps.parentSelector);
which means that, if the component is closed, newParent becomes currentParent in this cycle, and then the equality check is always true, even though the component did not get moved.
The text was updated successfully, but these errors were encountered:
Really, the issue is that the parentSelector will not cause a DOM update if the modal is not open when the parentSelector is changed. In componentWillReceiveProps,
which means that, if the component is closed, newParent becomes currentParent in this cycle, and then the equality check is always true, even though the component did not get moved.
The text was updated successfully, but these errors were encountered: