You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should probably stop relying on the deprecated property, and since React 18 dropped support for IE (which didn't support KeyboardEvent.code), I can't think of any blockers.
Using the deprecated property can already cause issues in browsers (or testing environments) that have removed support for it. I've ran into this using @testing-library/user-event (ref).
Happy to submit a PR for this!
The text was updated successfully, but these errors were encountered:
Hi! First of all, apologies for removing the issue template—since this isn't a bug report, I've found it hard to fill the reproduction steps.
I'm wondering if there's anything stopping us from switching from the deprecated
KeyboardEvent.keyCode
toKeyboardEvent.code
in theModalPortal
:react-modal/src/components/ModalPortal.js
Lines 276 to 285 in 0847049
We should probably stop relying on the deprecated property, and since React 18 dropped support for IE (which didn't support
KeyboardEvent.code
), I can't think of any blockers.Using the deprecated property can already cause issues in browsers (or testing environments) that have removed support for it. I've ran into this using
@testing-library/user-event
(ref).Happy to submit a PR for this!
The text was updated successfully, but these errors were encountered: