Remove the patch for event.code in the SidePanel spec #1808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
See testing-library/user-event#969 and reactjs/react-modal#952.
The issue was fixed upstream in
react-modal
by reactjs/react-modal#953 (released inreact-modal@3.16.1
). The version was bumped 15 minutes ago in #1804.This means that we can remove the workaround that we had in the
SidePanel
spec (patching the key event to ensure thatevent.keyCode
exists in the test env).Approach and changes
Removed the workaround, as described above.
Definition of done