Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the patch for event.code in the SidePanel spec #1808

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

robinmetral
Copy link
Contributor

Purpose

See testing-library/user-event#969 and reactjs/react-modal#952.

The issue was fixed upstream in react-modal by reactjs/react-modal#953 (released in react-modal@3.16.1). The version was bumped 15 minutes ago in #1804.

This means that we can remove the workaround that we had in the SidePanel spec (patching the key event to ensure that event.keyCode exists in the test env).

Approach and changes

Removed the workaround, as described above.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

The issue was addressed upstream in react-modal@3.16.1.
@robinmetral robinmetral requested a review from a team as a code owner October 24, 2022 07:26
@vercel
Copy link

vercel bot commented Oct 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
oss-circuit-ui ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 7:26AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2022

⚠️ No Changeset found

Latest commit: b31527c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sumup-oss sumup-oss deleted a comment from sumup-clark bot Oct 24, 2022
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #1808 (b31527c) into main (da04a39) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1808      +/-   ##
==========================================
- Coverage   91.26%   91.20%   -0.06%     
==========================================
  Files         170      170              
  Lines        3662     3662              
  Branches     1220     1220              
==========================================
- Hits         3342     3340       -2     
- Misses        301      303       +2     
  Partials       19       19              
Impacted Files Coverage Δ
...mponents/NotificationInline/NotificationInline.tsx 92.85% <0.00%> (-3.58%) ⬇️

@robinmetral robinmetral merged commit 0cfc199 into main Oct 24, 2022
@robinmetral robinmetral deleted the remove-event-patch-in-spec branch October 24, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants