Update README.md to include testing gotchas #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md to include testing gotchas
|
+1 This bit us in a big way and caused us to waste a lot of time before we thought to look at react-modal as the culprit and found the relevant issue A helpful notice upfront that it requires some special handling would've been really useful. |
|
@codegoblin It looks like you have 2 commits as part of this PR. Could you merge it to one to keep history clean? Then I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this has been a source of confusion not only within the issues section of this repo, but also within my software consultancy, I am proposing the addition of the included 'testing gotchas' section to the readme.