SSR fixes #1252

Judahmeek · 2023-02-13T05:53:54Z

Superseded by #1274

justin808 · 2023-02-14T07:43:40Z

@Judahmeek is this ready?

justin808 · 2023-02-14T07:44:03Z

lib/react/server_rendering/exec_js_renderer.rb

@@ -10,6 +10,7 @@ class ExecJSRenderer

      def initialize(options={})
        js_code = options[:code] || raise('Pass `code:` option to instantiate a JS context!')
+        # File.write("./tmp/latest_js_context.js", js_code, mode: "w+")


@Judahmeek remove comment?

I'd rather leave it there & then convert it into a proper trace log statement later on.

justin808 · 2023-02-14T07:44:50Z

test/react/server_rendering/webpacker_containers_test.rb

@@ -11,6 +11,8 @@ def test_it_loads_JS_from_the_webpacker_container
      WebpackerHelpers.compile
      container = React::ServerRendering::WebpackerManifestContainer.new
      assert_not_empty container.find_asset('application.js')
+      container = React::ServerRendering::SeparateServerBundleContainer.new
+      assert_not_empty container.find_asset('server_rendering.js')


How does this test work?

It really doesn't do much more than confirm that React::ServerRendering::SeparateServerBundleContainer.new.find_asset('server_rendering.js') doesn't throw an error.

But that's the same level of testing for React::ServerRendering::WebpackerManifestContainer that was already there so I'm simply applying the same standards.

RiccardoMargiotta · 2023-02-14T12:29:27Z

I can help test this if you can provide a bit more context around the issue. I already have SSR working with Shakapacker 6.5.5, but I do have the fix in place from Ryan's suggestion in #970 for splitChunks usage. Is this the same thing, or something different?

Judahmeek · 2023-02-15T04:02:07Z

@RiccardoMargiotta these changes have been tested against https://github.com/ahangarha/react-rails-with-shakapacker-for-ssr/tree/ssr-from-react_on_rail-dummy

As you'll see if you examine that repository, these changes are meant for a webpacker configuration in which the client & server bundles are compiled separately so the server bundle is no longer in the webpacker manifest.

ahangarha · 2023-02-16T15:20:49Z

@RiccardoMargiotta Do you have any public repo demonstrating the solution? I tried to apply the mentioned solution but couldn't make SSR work. It would be great to share to compare the performance and complexity of the two solutions.

RiccardoMargiotta · 2023-02-21T15:49:19Z

@ahangarha Nothing public, unfortunately. I'm not quite sure what I've been doing differently, although the main difference is probably that I don't make use of webpack-dev-server. I'll try to see if I can create a test app matching my setup.

Judahmeek · 2023-02-23T03:27:59Z

@ahangarha please let me know when you'll be able to complete the documentation for this PR or if you would prefer that I write it up.

ahangarha · 2023-02-23T08:02:21Z

@ahangarha please let me know when you'll be able to complete the documentation for this PR or if you would prefer that I write it up.

@Judahmeek I need to finish a task by Friday. After that, this is my priority.

justin808 · 2023-03-07T07:27:57Z

test/dummy_webpacker3/config/webpack/environment.js

@@ -1,3 +1,5 @@
 const { environment } = require('@rails/webpacker')


why support webpacker 3? it's too old!

Because decisions on what to support are above our pay-grade. 😂

justin808 · 2023-03-07T07:29:22Z

lib/react/server_rendering/bundle_renderer.rb

@@ -102,6 +103,8 @@ def assets_precompiled?
      def asset_container_class
        if self.class.asset_container_class.present?
          self.class.asset_container_class
+        elsif SeparateServerBundleContainer.compatible? && self.class.dont_use_webpacker_manifest


dont use webpacker manifest should be the ONLY case for SSR

using the webpack dev server for the server bundle is a flawed approach

I originally supported this for React on Rails, and that was a mistake.

justin808 · 2023-03-29T00:09:23Z

test/dummy_webpacker4/.babelrc

remove dummy_webpacker4

justin808 · 2023-04-06T21:05:14Z

@Judahmeek is this ready?

Judahmeek · 2023-05-03T22:51:32Z

.github/workflows/ruby.yml

@@ -6,39 +6,28 @@
 # For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby

 name: Ruby
-on: [push, pull_request]
+on: [push]


running on push & pull_request was redundant

justin808 · 2023-05-12T19:22:06Z

@Judahmeek we want to get this merged.

Judahmeek · 2023-05-18T03:18:30Z

Superseded by #1274

WIP

50debc6

Judahmeek changed the title ~~WIP~~ SSR fixes Feb 13, 2023

Judahmeek added 6 commits February 13, 2023 13:13

CI fix

f984e13

comment out debug logs

47443ca

disable filename hashing

adade56

clear up unnecessary code

faa3ee9

user editable variable

8e2df22

proper priority

f0ee42f

justin808 reviewed Feb 14, 2023

View reviewed changes

Judahmeek mentioned this pull request Feb 15, 2023

SSR (Server Side Rendering) with Shakapacker #1201

Closed

Judahmeek marked this pull request as ready for review February 23, 2023 03:24

Judahmeek requested review from justin808 and ahangarha and removed request for justin808 February 23, 2023 03:24

justin808 requested changes Mar 7, 2023

View reviewed changes

Judahmeek added 2 commits March 27, 2023 15:54

drop support for webpacker 3

dc72c2e

create shakapacker test

9f210b5

justin808 reviewed Mar 29, 2023

View reviewed changes

test/dummy_webpacker4/.babelrc Outdated

Copy link

Collaborator

justin808 Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove dummy_webpacker4

update Rakefile for last two changes

6ea7a48

Judahmeek force-pushed the judahmeek/ssr branch from ca3544f to 6ea7a48 Compare March 29, 2023 01:18

Judahmeek added 3 commits March 28, 2023 20:27

drop support for webpacker4

8acd981

edit to dummy_shakapacker

487fd17

remove reference to webpacker_manifest_container

7e7d676

justin808 force-pushed the master branch from 4a4d4e2 to 51988ef Compare March 30, 2023 09:16

only support shakapacker on 2.7.7

00687d9

Judahmeek force-pushed the judahmeek/ssr branch from 97ea808 to 00687d9 Compare March 30, 2023 23:06

Judahmeek added 6 commits March 30, 2023 19:36

simplify dummy location

0332dc6

sprockets is no longer available

429373c

remove redundant workflow

f0c2327

remove appraisal & add shakapacker

fb6817c

remove more appraisal references

6ce5492

change environment

fae9ba7

Judahmeek added 2 commits April 24, 2023 18:46

update test suite

9906259

update ubuntu for Github Actions

ced2f90

This was referenced Apr 25, 2023

Upgrade from Webpacker 3 to Shakapacker 7 and React-Rails 3 shakacode/react-rails-example-app#1

Merged

Update docs regarding HMR support #1253

Closed

Does react-rails support the latest version of Shakapacker/Webpacker? #1157

Closed

Judahmeek requested a review from justin808 April 26, 2023 07:24

Judahmeek added 3 commits April 26, 2023 16:18

CI fixes

23c4617

add sprocket v4 to gemspec dev dependencies

ce01772

CI fixes

5bfb21b

Judahmeek force-pushed the judahmeek/ssr branch from 9f6df3f to 5bfb21b Compare May 3, 2023 22:32

Judahmeek commented May 3, 2023

View reviewed changes

per self review

f23e0ce

Judahmeek force-pushed the judahmeek/ssr branch from fcd699b to f23e0ce Compare May 3, 2023 23:05

Judahmeek added 3 commits May 3, 2023 18:12

CI fix

082636c

add sprockets logic

1b52719

fix sentinel values

cc51f40

Judahmeek closed this May 18, 2023

Judahmeek deleted the judahmeek/ssr branch June 30, 2023 00:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SSR fixes #1252

SSR fixes #1252

Judahmeek commented Feb 13, 2023 •

edited

Loading

justin808 commented Feb 14, 2023

justin808 Feb 14, 2023

Judahmeek Feb 14, 2023

justin808 Feb 14, 2023

Judahmeek Feb 14, 2023

RiccardoMargiotta commented Feb 14, 2023

Judahmeek commented Feb 15, 2023

ahangarha commented Feb 16, 2023

RiccardoMargiotta commented Feb 21, 2023

Judahmeek commented Feb 23, 2023

ahangarha commented Feb 23, 2023

justin808 Mar 7, 2023

Judahmeek Mar 27, 2023

justin808 Mar 7, 2023

justin808 Mar 29, 2023

justin808 commented Apr 6, 2023

Judahmeek May 3, 2023

justin808 commented May 12, 2023

Judahmeek commented May 18, 2023

		@@ -1,3 +1,5 @@
		const { environment } = require('@rails/webpacker')

SSR fixes #1252

SSR fixes #1252

Conversation

Judahmeek commented Feb 13, 2023 • edited Loading

justin808 commented Feb 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RiccardoMargiotta commented Feb 14, 2023

Judahmeek commented Feb 15, 2023

ahangarha commented Feb 16, 2023

RiccardoMargiotta commented Feb 21, 2023

Judahmeek commented Feb 23, 2023

ahangarha commented Feb 23, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justin808 commented Apr 6, 2023

Choose a reason for hiding this comment

justin808 commented May 12, 2023

Judahmeek commented May 18, 2023

Judahmeek commented Feb 13, 2023 •

edited

Loading