Update code base based on sp7 #1285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin808
reviewed
Jul 14, 2023
| @@ -11,10 +11,11 @@ _Please add entries here for your pull requests that are not yet released._ | |||
|
|
|||
| ### Breaking Changes | |||
There was a problem hiding this comment.
Just require shakapacker v7 for v3 of react-rails so no older versions of webpacker, etc.
ahangarha
force-pushed
the
update-codebase-based-on-sp7
branch
from
9794c58 to
0e270ff
Compare
This is an internal attribute of React and it is removed since React 16. Despite this, it gets added in some cases, specially when we use the bundled react with Sprocket. We don't need to depend our tests on the existance of such attributes
Judahmeek
approved these changes
Jul 22, 2023
Judahmeek
approved these changes
Jul 22, 2023
@Judahmeek, May you be more specific? |
|
@ahangarha sorry. I was just experimenting with Github's review functionality. |
okuramasafumi
added a commit
to okuramasafumi/react-rails
that referenced
this pull request
Oct 18, 2023
https://github.com/reactjs/react-rails/blob/master/CHANGELOG.md > If using Webpacker/Shakapacker, requires upgrading to Shakapacker v7 reactjs#1274 and reactjs#1285 It looks like react-rails v3 supports Shakapacker v7 only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the code base based on Shakapacker 7.
Pull Request checklist