Skip to content

Chore/update appraisals #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 31, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 36 additions & 12 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ cache:
bundler: true
yarn: true
rvm:
- 2.5.1
- 2.3.7
- 2.6.2
- 2.5.3
- 2.3.8
- jruby-9.1.9.0

gemfile:
Expand All @@ -18,6 +19,8 @@ gemfile:
- gemfiles/rails_5_no_sprockets_webpacker_1_x.gemfile
- gemfiles/rails_5_no_sprockets_webpacker_2.gemfile
- gemfiles/rails_5_no_sprockets_webpacker_3.gemfile
- gemfiles/rails_5.2_no_sprockets_webpacker_3.gemfile
- gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile
# These don't have webpacker:
- gemfiles/rails_4.2_sprockets_2.gemfile
- gemfiles/rails_4.2_sprockets_3.gemfile
Expand All @@ -28,23 +31,44 @@ gemfile:
matrix:
fast_finish: true
exclude:

# all except 5.1_sprockets_4, 5.1_webpacker_3, 4.2_sprockets_3
- rvm: jruby-9.1.9.0
# Oldest rails does not run on ruby 2.6
- rvm: 2.6.2
gemfile: gemfiles/rails_4.2_sprockets_4.gemfile
- rvm: 2.6.2
gemfile: gemfiles/rails_4.2_sprockets_3.gemfile
- rvm: 2.6.2
gemfile: gemfiles/rails_4.2_sprockets_2.gemfile
- rvm: 2.5.3
- rvm: 2.3.8
- rvm: jruby-9.1.9.0
gemfile: gemfiles/rails_5_no_sprockets_webpacker_1_1.gemfile
- rvm: jruby-9.1.9.0
gemfile: gemfiles/rails_5_no_sprockets_webpacker_1_x.gemfile
- rvm: jruby-9.1.9.0
gemfile: gemfiles/rails_5_no_sprockets_webpacker_2.gemfile
- rvm: jruby-9.1.9.0

include:
# Oldest rails does not run on ruby 2.6
- rvm: 2.5.3
gemfile: gemfiles/rails_4.2_sprockets_4.gemfile
- rvm: 2.5.3
gemfile: gemfiles/rails_4.2_sprockets_3.gemfile
- rvm: 2.5.3
gemfile: gemfiles/rails_4.2_sprockets_2.gemfile
# Newest gemfiles for universal testing
- rvm: 2.5.3
gemfile: gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile
- rvm: 2.5.3
gemfile: gemfiles/rails_5.2_sprockets_4.gemfile
- rvm: 2.3.8
gemfile: gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile
- rvm: 2.3.8
gemfile: gemfiles/rails_5.2_sprockets_4.gemfile
- rvm: jruby-9.1.9.0
gemfile: gemfiles/rails_5_no_sprockets.gemfile
gemfile: gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile
- rvm: jruby-9.1.9.0
gemfile: gemfiles/rails_5.2_sprockets_4.gemfile

allow_failures:
- rvm: jruby-9.1.9.0
gemfile: gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile
- rvm: jruby-9.1.9.0
gemfile: gemfiles/rails_5.2_sprockets_4.gemfile

before_install:
# Repo for Yarn
Expand Down
14 changes: 14 additions & 0 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,20 @@ appraise 'rails-5.2-sprockets_4' do
gem 'turbolinks', '~> 5'
end

appraise 'rails-5.2_no_sprockets_webpacker_3' do
gem 'rails', '~> 5.2.0'
gem 'webpacker', '~> 3.0'
gem 'mini_racer', :platforms => :mri
gem 'therubyrhino', :platforms => :jruby
end

appraise 'rails-5.2_no_sprockets_webpacker_4' do
gem 'rails', '~> 5.2.0'
gem 'webpacker', '~> 4.0'
gem 'mini_racer', :platforms => :mri
gem 'therubyrhino', :platforms => :jruby
end

appraise 'rails-5.1-sprockets_4' do
gem 'rails', '~> 5.1.0'
gem 'sprockets', '~> 4.0.x'
Expand Down
10 changes: 10 additions & 0 deletions gemfiles/rails_5.2_no_sprockets_webpacker_3.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# This file was generated by Appraisal

source "http://rubygems.org"

gem "rails", "~> 5.2.0"
gem "webpacker", "~> 3.0"
gem "mini_racer", platforms: :mri
gem "therubyrhino", platforms: :jruby

gemspec path: "../"
10 changes: 10 additions & 0 deletions gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# This file was generated by Appraisal

source "http://rubygems.org"

gem "rails", "~> 5.2.0"
gem "webpacker", "~> 4.0"
gem "mini_racer", platforms: :mri
gem "therubyrhino", platforms: :jruby

gemspec path: "../"
2 changes: 1 addition & 1 deletion react-rails.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Gem::Specification.new do |s|
s.email = ['paul@oshannessy.com', 'rmosolgo@gmail.com', 'neonmd@hotmail.co.uk', 'info@ttanimichi.com']

s.add_development_dependency 'appraisal'
s.add_development_dependency 'bundler', '>= 1.2.2'
s.add_development_dependency 'bundler', '>= 1.2.2', '< 2.0'
s.add_development_dependency 'codeclimate-test-reporter'
s.add_development_dependency 'coffee-rails'
s.add_development_dependency 'es5-shim-rails', '>= 2.0.5'
Expand Down