Skip to content

Keep variable name case sensitive on assert_react_component props. #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Keep variable name case sensitive on assert_react_component props. #979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/react/rails/test_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ def assert_react_component(name)
assert_select "div[data-react-class=?]", name do |dom|
if block_given?
props = JSON.parse(dom.attr("data-react-props"))
props.deep_transform_keys! { |key| key.to_s.underscore }
props.deep_symbolize_keys!

yield(props)
Expand Down
2 changes: 1 addition & 1 deletion test/dummy_sprockets/app/views/pages/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
</ul>

<div id='component-parent'>
<%= react_component 'GreetingMessage', { name: @name, last_name: "Last #{@name}", info: { name: @name } }, { id: 'component', class: "greeting-message", prerender: @prerender } %>
<%= react_component 'GreetingMessage', { name: @name, lastName: "Last #{@name}", info: { name: @name, lastName: "Last #{@name}" } }, { id: 'component', class: "greeting-message", prerender: @prerender } %>
<ul>
<%= react_component 'Todo', { todo: 'Another Component' }, { id: 'todo', prerender: @prerender } %>
</ul>
Expand Down
2 changes: 1 addition & 1 deletion test/dummy_webpacker1/app/views/pages/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
</ul>

<div id='component-parent'>
<%= react_component 'GreetingMessage', { name: @name, last_name: "Last #{@name}", info: { name: @name } }, { id: 'component', class: "greeting-message", prerender: @prerender } %>
<%= react_component 'GreetingMessage', { name: @name, lastName: "Last #{@name}", info: { name: @name, lastName: "Last #{@name}" } }, { id: 'component', class: "greeting-message", prerender: @prerender } %>
<ul>
<%= react_component 'Todo', { todo: 'Another Component' }, { id: 'todo', prerender: @prerender } %>
</ul>
Expand Down
2 changes: 1 addition & 1 deletion test/dummy_webpacker2/app/views/pages/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
</ul>

<div id='component-parent'>
<%= react_component 'GreetingMessage', { name: @name, last_name: "Last #{@name}", info: { name: @name } }, { id: 'component', class: "greeting-message", prerender: @prerender } %>
<%= react_component 'GreetingMessage', { name: @name, lastName: "Last #{@name}", info: { name: @name, lastName: "Last #{@name}" } }, { id: 'component', class: "greeting-message", prerender: @prerender } %>
<ul>
<%= react_component 'Todo', { todo: 'Another Component' }, { id: 'todo', prerender: @prerender } %>
</ul>
Expand Down
2 changes: 1 addition & 1 deletion test/dummy_webpacker3/app/views/pages/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
</ul>

<div id='component-parent'>
<%= react_component 'GreetingMessage', { name: @name, last_name: "Last #{@name}", info: { name: @name } }, { id: 'component', class: "greeting-message", prerender: @prerender } %>
<%= react_component 'GreetingMessage', { name: @name, lastName: "Last #{@name}", info: { name: @name, lastName: "Last #{@name}" } }, { id: 'component', class: "greeting-message", prerender: @prerender } %>
Copy link
Member

@BookOfGreg BookOfGreg Apr 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the same in the other dummy applications?
That should make the tests pass.

test/dummy_sprockets/app/views/pages/show.html.erb
test/dummy_webpacker1/app/views/pages/show.html.erb
test/dummy_webpacker2/app/views/pages/show.html.erb

Copy link
Member

@BookOfGreg BookOfGreg Apr 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask you to also get the one in this file please?
https://github.com/reactjs/react-rails/blob/master/test/dummy_sprockets/app/views/pages/show.html.erb

<ul>
<%= react_component 'Todo', { todo: 'Another Component' }, { id: 'todo', prerender: @prerender } %>
</ul>
Expand Down
3 changes: 2 additions & 1 deletion test/react/rails/test_helper_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ class TestHelperTest < ActionDispatch::IntegrationTest
assert_react_component "GreetingMessage"
assert_react_component "GreetingMessage" do |props|
assert_equal "Bob", props[:name]
assert_equal "Last Bob", props[:last_name]
assert_equal "Last Bob", props[:lastName]
assert_equal "Bob", props[:info][:name]
assert_equal "Last Bob", props[:info][:lastName]

assert_select "[id=?]", "component"
assert_select "[class=?]", "greeting-message"
Expand Down