Skip to content
This repository was archived by the owner on Oct 26, 2018. It is now read-only.
This repository was archived by the owner on Oct 26, 2018. It is now read-only.

Request for custom Link #409

@fingermark

Description

@fingermark

This will likely get shot down, but I just wanted to bring it up in case I was doing something wrong.

I needed to use activeClassName on my react-router Link and found that it would only work intermittently. I had to pass {pure: false} to redux's connect for it to work 100% of them. Once I did that my component with the <Link /> was rendering whenever any state changed. After talking with someone on IRC they mentioned that it's because shouldComponentUpdate and context aren't mixing well.

The only solution I could come up with was to create my own custom Link component that reads the router state.

Would it be possible for react router to implement this component for us in the future?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions